search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.27k stars 28.57k forks source link

macOS: Font weight is permanently bold after latest update #224496

Closed jgarber623 closed 1 month ago

jgarber623 commented 1 month ago

214390 appears to be back in the just-released v1.92.0. I'm experiencing the issue as previously reported (and later resolved in v1.90.1):

I use Operator Mono first this issue occurred in Insider release, and now with the latest release both versions of VS Code only show bold font weight. 300 is too thin. 400 is too bold. This wasn't the case before.

Version: 1.92.0
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 22.6.0
kking-redica commented 1 month ago

Experiencing the same issue after just updating. 


Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.5.0```
trevorwright commented 1 month ago

Appears to be a regression of this issue: https://github.com/microsoft/vscode/issues/214390

The same fix from last time works again. Quit out of VSCode and then launch it from your terminal with the following command

open -a "Visual Studio Code" --args --disable-blink-features=FontMatchingCTMigration
leademeule commented 1 month ago

I am also experiencing this regression. See this comment for documentation and screenshots.

leademeule commented 1 month ago

@trevorwright thank you for sharing, this fixes it on my side. Hopefully this can be properly patched sometime soon.

rigobauer commented 1 month ago

Same problem here

kowsar89 commented 1 month ago

I'm using Ubuntu 22.04 and font looks funny and bigger after the update (v1.92.0), screenshot: https://prnt.sc/Twi3ckgzi0YA

Version: 1.92.0
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Linux x64 6.6.22-060622-generic
guymarshall commented 1 month ago

I am using Linux Mint and the font has also suddenly increased in size after the update like @kowsar89

JMadgwick commented 1 month ago

I also have this problem, using Linux and not MacOS. I also see the bolded font in the right click menu. I never previously had this problem in any version I'd used before.

michael-andreuzza commented 1 month ago

Appears to be a regression of this issue: #214390

The same fix from last time works again. Quit out of VSCode and then launch it from your terminal with the following command

open -a "Visual Studio Code" --args --disable-blink-features=FontMatchingCTMigration

Thank you for sharing this.

helloromero commented 1 month ago

@michael-andreuzza THANK YOU!!! I can't express how much I was about to give up on being a developer lol

mrwigster commented 1 month ago

Same issue as last time, my fix from last time seems to work: https://github.com/microsoft/vscode/issues/214390#issuecomment-2154931444 For anyone else wondering, open VS using terminal with the below command:

open -a "Visual Studio Code" --args --disable-blink-features=FontMatchingCTMigration

michael-andreuzza commented 1 month ago

@michael-andreuzza THANK YOU!!! I can't express how much I was about to give up on being a developer lol

it wasn't my my man...it was @trevorwright solution :-)

deepak1556 commented 1 month ago

https://chromium.googlesource.com/chromium/src/+/98eb1392b060711dc30dbc9d1b07fe6c4147e0ff was confirmed to address the postscript name matching in https://github.com/microsoft/vscode/issues/214390#issuecomment-2154822715. However the font weight matching is still regressed with the core text path for certain fonts and seems like https://chromium.googlesource.com/chromium/src/+/3bef104fb08126b6b68bab46b0ce132e1cc574a7 accidentally addresses it by using the appkit path as default which is available from Chromium 125. Issue is however present with the core text path in latest canary --enable-blink-features=FontFamilyStyleMatchingCTMigration. I will disable the CT engine again as candidate fix and follow-up in upstream to address the root issue.

deepak1556 commented 1 month ago

Steps for verification:

KoreSamuel commented 1 month ago 
Version: 1.92.0 (Universal)
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.3.0

same issue, it looked like have appeared before. And open -a "Visual Studio Code" --args --disable-blink-features=FontMatchingCTMigration works for me after using Command + Q to quit vscode.

deepak1556 commented 1 month ago

Closing for verification.

jgarber623 commented 1 month ago

@deepak1556 Thanks for sorting this one out!

isidorn commented 1 month ago

Adding verified.

Before (broken) it looked like

Image

Now with the fix it looks like

Image

Users - if something is off in this image do let us know!

dannyuk1982 commented 1 month ago

It's still broken for me, behaviour is normal using open -a "Visual Studio Code" --args --disable-blink-features=FontMatchingCTMigration but directly launching the app results in it being stuck on bold using Operator Mono

Version: 1.92.0
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z (1 wk ago)
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.5.0
isidorn commented 1 month ago

@dannyuk1982 the fix has not yet been released in stable. Should be out in next 24h

bpasero commented 1 month ago

Should be out now.

dannyuk1982 commented 1 month ago

@bpasero yup that is working fine for me! thanks

kowsar89 commented 4 weeks ago

I'm using Ubuntu 22.04 and font looks funny and bigger after the update (v1.92.0), screenshot: https://prnt.sc/Twi3ckgzi0YA

Version: 1.92.0
Commit: b1c0a14de1414fcdaa400695b4db1c0799bc3124
Date: 2024-07-31T23:26:45.634Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Linux x64 6.6.22-060622-generic

I don't think it's fixed for me after the update ie.

Version: 1.92.1
Commit: eaa41d57266683296de7d118f574d0c2652e1fc4
deepak1556 commented 4 weeks ago

@kowsar89 this issue is specific to macOS, can you open a separate issue for your case. Thanks!

guymarshall commented 3 weeks ago

@kowsar89 this issue is specific to macOS, can you open a separate issue for your case. Thanks!

Multiple people (me included) have said this issue also affects Linux but for some reason macOS was put in the title and other OSes were ignored.

jgarber623 commented 3 weeks ago

I'm not impacted by the Linux issues, but I took up @deepak1556's suggestion above and opened an issue for y'all: https://github.com/microsoft/vscode/issues/225434