microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.94k stars 29.18k forks source link

Searching all and refactoring variables finding everything #224580

Closed nistre closed 2 months ago

nistre commented 3 months ago

Type: Bug

When trying to Search (Ctrl+Shift+F) I am only getting limited results that exist with my Explorer view, perhaps only the files currently open or recently opened are found. A similar issue occurs when refactoring where only a limited number of variable references in other files get refactored. I should note I am using VS Code in a monolithic repo, so if it is a matter of the size, it would be nice for the Search/Refactoring to give an inidication it is loading to find/rename all the instances.

VS Code version: Code 1.92.0 (b1c0a14de1414fcdaa400695b4db1c0799bc3124, 2024-07-31T23:26:45.634Z) OS version: Windows_NT x64 10.0.19045 Modes: Unsupported

System Info |Item|Value| |---|---| |CPUs|12th Gen Intel(R) Core(TM) i7-12850HX (24 x 2419)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|31.69GB (13.25GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (33) Extension|Author (truncated)|Version ---|---|--- Bookmarks|ale|13.5.0 project-manager|ale|12.8.0 swagger-viewer|Arj|3.1.2 npm-intellisense|chr|1.4.5 gitignore|cod|0.9.0 vscode-eslint|dba|3.0.10 dendron|den|0.124.0 dendron-markdown-shortcuts|den|0.12.1 dendron-paste-image|den|1.1.1 githistory|don|0.6.20 gitlens|eam|15.2.3 EditorConfig|Edi|0.16.4 vscode-jest-runner|fir|0.4.73 todo-tree|Gru|0.0.226 vscode-drawio|hed|1.6.6 vscode-peacock|joh|4.2.2 openapi-lint|mer|1.2.0 git-graph|mhu|1.30.0 tabscolor|mon|0.2.4 vscode-docker|ms-|1.29.1 csharp|ms-|2.39.29 vscode-dotnet-runtime|ms-|2.1.1 vscode-edge-devtools|ms-|2.1.5 remote-containers|ms-|0.380.0 remote-explorer|ms-|0.4.3 remote-server|ms-|1.5.2 vsliveshare|ms-|1.0.5936 angular-console|nrw|18.25.0 material-icon-theme|PKi|5.8.0 vscode-yaml|red|1.15.0 code-spell-checker|str|3.0.1 vscode-conventional-commits|viv|1.25.0 vscode-icons|vsc|12.8.0
andreamah commented 2 months ago

Image

If you click the 3 dots that I point to here, is the circled button toggled on?

andreamah commented 2 months ago

Also, is it finished loading when it only shows limited files? Is it still showing the loading animation?

nistre commented 2 months ago

The button is not toggled on. I do see (guessing I just didn't see it before) a loading icon on the Status Bar. Is that the loading animation you are referring to?

andreamah commented 2 months ago

Yes. It seems that the search is taking a long time on your project. Have you considered adding some paths to the search.excludes setting to make the search more optimized? I would assume that, since you're in a mono-repo, it's searching through many files, which may take a long time.

nistre commented 2 months ago

Gotcha, I'll refine the excludes the next time I need to refactor/search. I guess I didn't see the loading icon in the Status Bar to know it was still loading. v/r