search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.64k stars 28.69k forks source link

Make dropdown control looks more consistent with other parts #224780

Open RichardLuo0 opened 1 month ago

RichardLuo0 commented 1 month ago

image Control like this uses native select control. I think there are several drawbacks:

  1. No smooth scrolling
  2. No shadow
  3. It's hard to change its appearance or extend its function in the future. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select#styling_with_css
  4. The separator is of the same height as other options and not enough width (since it's just a disabled option with text ----). It should be like in the normal menu, extending to both sides and having a smaller height.

Therefore I suggest using a custom control instead.

justschen commented 1 month ago

looks like the output selector, is this @sandy081 ?

RichardLuo0 commented 1 month ago

looks like the output selector, is this @sandy081 ?

There is also one for debug config selection

RichardLuo0 commented 1 month ago

I was mistaken about the native select control part. It is indeed a custom control. But imo it looks too out of line with the rest of vscode (it looks exactly like the web select control). So my other points still hold.

sandy081 commented 2 weeks ago

I do not know who owns the Select dropdown, @sbatten assigning to you assuming that it comes under custom UI elements in VS Code.