search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.35k stars 28.6k forks source link

Notebooks check object leaks smoketest failure #224924

Open alexr00 opened 1 month ago

alexr00 commented 1 month ago 
 1) VSCode Smoke Tests (Web)
       Notebooks
         check object leaks:
     Error: Timeout: get element '.notebook-editor .monaco-list-row.focused' after 20 seconds.
      at Code.poll (/Users/runner/work/1/s/test/automation/out/code.js:204:23)
      at async Code.waitForElement (/Users/runner/work/1/s/test/automation/out/code.js:163:16)
      at async Notebook.openNotebook (/Users/runner/work/1/s/test/automation/out/notebook.js:18:9)
      at async /Users/runner/work/1/s/test/smoke/out/areas/notebook/notebook.test.js:35:17
      at async Profiler.checkObjectLeaks (/Users/runner/work/1/s/test/automation/out/profiler.js:17:9)
      at async Context.<anonymous> (out/areas/notebook/notebook.test.js:34:13)

https://monacotools.visualstudio.com/Monaco/_build/results?buildId=286726&view=results

alexr00 commented 1 month ago

Skipping test with https://github.com/microsoft/vscode/pull/224923

neehhaa06 commented 1 month ago

Hello @alexr00 :)

fix: #224924

I suggest you to, Increase the timeout for waiting and repeatedly check for the presence of the element using a loop with a short delay. This approach accounts for potential delays in rendering and ensures the element is available before proceeding.

rebornix commented 1 month ago

I don't understand yet why it's failing in Browser, from the screenshot it seems the web view can't be resolved. I'll troubleshoot that separately, and enable notebook smoke test only for electron. Thanks for taking care of it!