search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.43k stars 28.95k forks source link

Sorting comments uses filter icon, not a sort icon #226763

Open Tyriar opened 1 month ago

Tyriar commented 1 month ago

Testing #226657

While filtering is certainly related to sorting, they're different things. I was not expecting sort actions to be there:

image

I see we have this icon:

image

But I was expecting one like this:

image

or

image

alexr00 commented 1 month ago

This was inspired by the extensions view. @daviddossett is there a canonical way we do this?

daviddossett commented 1 month ago

It looks like we do this in extensions but I agree that it's weird to have filter be the entry point. Seems like the main difference today is that the Comments view doesn't add the input tag e.g.

Image

Empty input here

Image

This probably wants to be a toggle more like like Search view's View as Tree | View as List button. Ideally living on the Comments view toolbar, not with the filter.

alexr00 commented 1 month ago

Makes sense, thank you for weighing in!