Improve name/description of theme keys - Githubissues

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

162.45k stars 28.62k forks source link

Improve name/description of theme keys #226802

Open Tyriar opened 2 weeks ago

Tyriar commented 2 weeks ago

Testing #226648

It's not immediately clear what a group is here:

https://github.com/microsoft/vscode/blob/78f4b54aca1c0e9b0b86f2e650e22ceb7217ccba/src/vs/workbench/contrib/scm/browser/scmHistory.ts#L25-L27

I think it would be more clean if these were named:

scm.graph.localItemForeground
- Since the feature is called "source control graph", the history seems unneeded?
- Foreground/background/border is normally a suffix of theme keys
scm.graph.remoteItemForeground
scm.graph.mergeBaseItemForeground
- I think base means merge base here?

lszomoru commented 2 weeks ago

HistoryItemGroup is a term that we have been using but will have to be cleaned up as we move the API towards finalization.