Cell Diff has 'A' for label it should be styled differently since it is modification SCM status

karthiknadig commented 3 months ago

Type: Bug

Cell Diff has 'A' as label along with cell number.

VS Code version: Code - Insiders 1.93.0-insider (ae45c9d4b0f71d53151edc6d18be09107903c229, 2024-08-29T05:04:03.909Z) OS version: Windows_NT x64 10.0.22631 Modes:

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|31.60GB (16.67GB free)| |Process Argv|--log info --log ms-python.python=info --crash-reporter-id 4fb1ebc1-cf4c-4880-a88a-47738ec3768d| |Screen Reader|no| |VM|0%|

Extensions (22)

Extension|Author (truncated)|Version ---|---|--- tsl-problem-matcher|amo|0.6.2 ruff|cha|2024.42.0 vscode-eslint|dba|3.0.10 gitlens|eam|15.3.1 EditorConfig|Edi|0.16.4 prettier-vscode|esb|11.0.0 copilot|Git|1.223.1074 copilot-chat|Git|0.20.2024082901 vscode-github-actions|git|0.26.3 vscode-pull-request-github|Git|0.95.2024082904 copilot-for-security|Mic|0.3.1 vscode-language-pack-de|MS-|1.93.2024082809 debugpy|ms-|2024.10.0 python|ms-|2024.13.2024082701 vscode-pylance|ms-|2024.8.2 jupyter|ms-|2024.8.2024081201 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.19 vscode-jupyter-cell-tags|ms-|0.1.9 vscode-jupyter-slideshow|ms-|0.1.6 remote-wsl|ms-|0.88.2 code-spell-checker|str|3.0.1

A/B Experiments

``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 vsc_aacf:30263846 vscod805cf:30301675 vsaa593cf:30376535 py29gd2263:31024238 c4g48928:30535728 vscrpc:30624061 a9j8j154:30646983 962ge761:30841072 pythongtdpath:30726887 welcomedialog:30812478 pythonnoceb:30776497 asynctok:30898717 dsvsc014:30777825 dsvsc015:30821418 pythonregdiag2:30926734 pythonmypyd1:30859725 h48ei257:31000450 pythontbext0:30879054 accentitlementst:30870582 dsvsc016:30879898 dsvsc017:30880771 dsvsc018:30880772 cppperfnew:30980852 pythonait:30973460 0ee40948:31013168 a69g1124:31018687 dvdeprecation:31040973 dwnewjupytercf:31046870 newcmakeconfigv2:31071590 impr_priority:31057980 nativerepl1:31104042 refactort:31084545 pythonrstrctxt:31093868 flighttreat:31119334 wkspc-onlycs-c:31111717 nativeloc1:31118317 wkspc-ranged-c:31125598 jh802675:31111929 notreesitter:31116712 e80f6927:31120813 ei213698:31121563 aajjf12562:31125793 ```

DonJayamanne commented 3 months ago

Expected functionality from multi file diff viewer Added = A

karthiknadig commented 3 months ago

@DonJayamanne on the SCM view I can hover on A or M, and it provides details:

The colorization and no hover on that makes it look like some label or title.

karthiknadig commented 3 months ago

@DonJayamanne The issue is that hovering on the A does not give detailed info on what it is. Modified cells don't have M. So it is in consistent. So it can certainly be improved. Ask is:

Style it differently so it does not look like a title
Add hover so that it provides additional details like the SCM view hover

hediet commented 2 months ago

@DonJayamanne Can you clarify the ask for me here? This looks like a notebook multi file diff editor integration issue.