microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.62k stars 28.67k forks source link

Do not disable `local/code-import-patterns` ESLint rule #227752

Open jrieken opened 1 week ago

jrieken commented 1 week ago

There should exist no reason to disable the local/code-import-patterns. You either need to move things into the right layer or update the configuration of the rule

aeschli commented 1 week ago

colorRegistry.releaseTest.ts has a import '../../../../workbench.desktop.main.js'; to make sure all parts of VS Code are loaded and registerColor calls are made. I don't think we have a layer for that, but I can move the test one up to src/vs/workbench/contrib/themes/test/ Is that ok and beneficial?