search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.21k stars 29.29k forks source link

[Accessibility] Chat show: make delete key work to remove focused history #228035

Open jooyoungseo opened 2 months ago

jooyoungseo commented 2 months ago

Type: Feature Request

CC @meganrogge

  1. Run "Chat: Show Chats..."

  2. Use Up/DownArrow to focus in any recent chat title

  3. Press Delete key to see if that removes the focused chat

Suggested Behavior

Make the Delete key work to remove the focused Chat history for SR and keyboard-only users.

VS Code version: Code - Insiders 1.94.0-insider (dc9412125d4e0a480593962ae2687e74e64af728, 2024-09-09T17:10:54.809Z) OS version: Windows_NT x64 10.0.22631 Modes:

meganrogge commented 2 months ago

@roblourens WDYT of this? wouldn't want users to do this accidentally and there is already a way to do this via keyboard, but it does require several keystrokes.

roblourens commented 2 months ago

The thing is, focus stays in the input box, and you are in a text editing context, so Delete should still do a text delete. You can tab to the toolbar on quickpick items though.

There could be another keybinding for this, but it should work the same in all quickpicks that have a remove action.

meganrogge commented 2 months ago

I am not convinced this action happens frequently enough to warrant a new keybinding. I'll keep this open to get more feedback.

Also cc @TylerLeonhardt re having this work in all quickpicks.

vs-code-engineering[bot] commented 2 months ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

TylerLeonhardt commented 2 months ago

Delete doesn't really apply to most quick picks. There is a class of quick picks that do support this like the "recently opened" list in the file picker... but it's really not that common.

I agree that we should see if this is really needed over what's available (tabbing to an x button for the item)

vs-code-engineering[bot] commented 1 week ago

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!