microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.53k stars 29.4k forks source link

Consider moving entries in search view into overflow by default #228953

Open Tyriar opened 2 months ago

Tyriar commented 2 months ago

Default state:

Image

Image

To reduce complexity, I think we should hide the less important items into an overflow. For example this:

Image

Or:

Image

andreamah commented 1 month ago

Makes sense. It sort of messes with muscle memory, though. I wonder if there's a way that we can customize what goes there, sort of like the icons near the markdown preview icon. 🤔

Image

@daviddossett ideas?

Tyriar commented 1 month ago

I wouldn't want to remove them outright, I'm suggesting just like in the terminal view that there are some hidden entries by default:

Image

Some of these were popular requests (clear/run) that I refused to show by default due to the noise, some were added to increase discoverability (scroll). So a user that wants them can right click to add them back, but the default user who probably doesn't want to use them or very rarely does, will get a simpler UI.

This is done via the isHiddenByDefault flag I added:

https://github.com/microsoft/vscode/blob/1e80dd664a0e5346012ebe4097a3d32079ac050c/src/vs/workbench/contrib/terminal/browser/terminalActions.ts#L1011-L1019

daviddossett commented 1 month ago

I'd be happy to have fewer icons there by default too. Clear Search Results and Collapse All feel like must-haves. The others not so much but that could just be my usage.

andreamah commented 1 month ago

We could explore this. Maybe hiding the tree/list toggle and also the refresh.