vscode does not respect GIT_AUTHOR_NAME/EMAIL in pre-commit hook failures, setting git.requireGitUserConfig=false has no effect

[juliannadeau-stripe]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: Version: 1.92.1 (Universal)
• OS Version: Mac OS Sonoma 14.6.1

Steps to Reproduce:

1. add a pre-commit hook that exits 1 (for whatever reason)
2. do not set git config for user.name or user.email
3. set configs using GIT_AUTHOR_NAME / GIT_AUTHOR_EMAIL
4. Try to commit using the source control pane
5. See error about user.name/email despite being set

Notes:

• This only fails if a pre-commit hook fails (which is valid!)
• If the configs are set directly using git config, you get the output of the pre-commit hook instead of the screenshot above
• git.requireGitUserConfig is set to false
• The issue is in these lines of code https://github.com/microsoft/vscode/blob/07e6c39831b3ac1cabc1c228502a48788c4244c8/extensions/git/src/git.ts#L1743-L1754 which make a false assumption about how these are set
• Similar yet separate issues:
  • https://github.com/microsoft/vscode/issues/128704
  • https://github.com/microsoft/vscode/issues/173442

[vs-code-engineering[bot]]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.93.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[juliannadeau-stripe]

To respond to vs-code-engineering, I read the source code and it persists until main branch.