search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.66k stars 28.68k forks source link

Terminal: voice recording no longer stops when submitted #229025

Open bpasero opened 2 days ago

bpasero commented 2 days ago

Steps to Reproduce:

  1. start inline chat in terminal with voice
  2. speak something so that input gets filled
  3. wait until it gets auto submitted

=> 🐛 the recording does not stop

This relies on terminalChat.onDidAcceptInput to fire which no longer seems to be the case:

https://github.com/microsoft/vscode/blob/c2d40bee71a1cd38146754402fa1c08d4ef0b03a/src/vs/workbench/contrib/chat/electron-sandbox/actions/voiceChatActions.ts#L224

meganrogge commented 1 day ago

this happened recently https://github.com/microsoft/vscode/pull/229004

meganrogge commented 1 day ago

We have to use our own menu, which was removed in the above PR. See https://github.com/microsoft/vscode/issues/208789