microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.52k stars 29.39k forks source link

Long chat attachment filenames cause chat input to overflow #229419

Open mjbvz opened 1 month ago

mjbvz commented 1 month ago

Type: Bug

  1. Attach a file with a very long name to chat

Bug The widget expands so that you can't see the submit buttons anymore:

Image

VS Code version: Code - Insiders 1.94.0-insider (Universal) (1926933184de3f77ac7176e9fc302c54bd9634b0, 2024-09-23T05:12:01.964Z) OS version: Darwin arm64 23.6.0 Modes:

System Info |Item|Value| |---|---| |CPUs|Apple M2 Max (12 x 2400)| |GPU Status|2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: disabled_software
video_encode: disabled_software
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software
webnn: disabled_off| |Load (avg)|4, 4, 4| |Memory (System)|64.00GB (1.13GB free)| |Process Argv|--crash-reporter-id 0fffb5da-9cd7-46fd-9e7f-a1564e8c5fda| |Screen Reader|no| |VM|0%|
A/B Experiments ``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805:30301674 vsaa593cf:30376535 py29gd2263:31024238 c4g48928:30535728 a9j8j154:30646983 962ge761:30841072 pythongtdpath:30726887 welcomedialog:30812478 pythonnoceb:30776497 asynctok:30898717 dsvsc014:30777825 dsvsc015:30821418 pythonmypyd1:30859725 h48ei257:31000450 pythontbext0:30879054 accentitlementst:30870582 dsvsc016:30879898 dsvsc017:30880771 dsvsc018:30880772 cppperfnew:30980852 pythonait:30973460 724cj586:31013169 a69g1124:31018687 dvdeprecation:31040973 dwnewjupytercf:31046870 impr_priority:31057980 nativerepl1:31134653 refactort:31084545 pythonrstrctxt:31093868 flighttreat:31119334 wkspc-onlycs-t:31132770 nativeloc1:31118317 wkspc-ranged-t:31125599 jh802675:31132134 e80f6927:31120813 ei213698:31121563 i21gd607:31141543 notype1:31143044 b50ed353:31138333 showbadge:31139796 f8igb616:31140137 ```
justschen commented 1 month ago

@roblourens I actually see this instead

Screenshot 2024-09-23 at 1 36 26 PM

Screenshot 2024-09-23 at 1 36 53 PM

roblourens commented 1 month ago

Depends on if it wraps or not- we should either get them to truncate nicely, like with max-width and text-overflow, or force them to wrap but render the border around the wrapped widget properly.