search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.94k stars 29.18k forks source link

Consider to convert `src/vs/workbench/contrib/webview/browser/pre/service-worker.js` to TypeScript #229879

Open bpasero opened 1 month ago

bpasero commented 1 month ago

Given we now run with ESM, there is no real reason anymore to have JS files in our sources.

https://github.com/microsoft/vscode/blob/9e23739d0b9f3381d99be9bde649709d4329daa5/src/vs/workbench/contrib/webview/browser/pre/service-worker.js#L1-L8

mjbvz commented 2 days ago

This code will run inside a webview. May be possible to convert but we'd need to add a new entryPoint for it, right?

bpasero commented 2 days ago

Wouldn't the entry point be the same in the end? We still compile to JS into the out folder 🤔