search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.91k stars 28.76k forks source link

Sometimes links don't work the first time you click #230010

Open Tyriar opened 5 hours ago

Tyriar commented 5 hours ago

Repro seems somewhat reliable:

  1. Run ls or get-childitem in terminal
  2. Hold ctrl/cmd
  3. Click the links quickly, the first time you click a link after moving to it may not work

Image

Tyriar commented 5 hours ago

activate is never reached in this case:

https://github.com/microsoft/vscode/blob/e0ca49c84aae9afbf9dac924e99dad3b27c0ce83/src/vs/workbench/contrib/terminalContrib/links/browser/terminalLink.ts#L52-L54

Tyriar commented 5 hours ago

Upstream fix: https://github.com/xtermjs/xterm.js/pull/5171