search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.93k stars 29.52k forks source link

[Accessibility] Show Code Actions menu item selected state not being announced correctly in screenreader #231070

Open gdomingu opened 1 month ago

gdomingu commented 1 month ago

Environment Details:

Application Name: VS Code Visual studio code: 1.94.2 (Universal) Copilot chat: v0.21.1 Windows 11 Home 23H2

Actual Result:​

Screenreader (NVDA, VoiceOver) announces not selected. When navigating on code actions menu.

Expected Result:​

Screenreader should not announce not selected nor selected for single select box.

Repro steps:

  1. Select a code snippet.
  2. Open the code actions menu by clicking the lightbulb button or using (control + . / command + .)
  3. Navigate up and down the menu using the up and down keys.
  4. Hear the screenreader announce not selected.

Image

meganrogge commented 1 month ago

I notice you're not in screen reader optimized mode. If you enable that (with the toggle screen reader optimized mode command), does this change?

meganrogge commented 1 month ago

related: https://github.com/microsoft/vscode/issues/152228

meganrogge commented 1 month ago

see https://github.com/microsoft/vscode/issues/152228#issuecomment-2411661926 with the recommendation to close the issue as invalid.

gdomingu commented 1 month ago

I notice you're not in screen reader optimized mode. If you enable that (with the toggle screen reader optimized mode command), does this change?

@meganrogge No it does not change even when in screen reader optimized mode.

Image of NVDA screenreader log showing not selected

see https://github.com/microsoft/vscode/issues/152228#issuecomment-2411661926 with the recommendation to close the issue as invalid.

I would ask that this issue be kept open since this is not for the run and debug dialog menu.

meganrogge commented 1 month ago

Listening to screen reader users on this one, I think this shld be closed. Their argument abt the existing behavior in run and debug also applies here.