microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.66k stars 29.05k forks source link

GitHub Copilot Reference Links Disrupt NVDA Screen Reader #231506

Open jeanbrazcosta opened 6 days ago

jeanbrazcosta commented 6 days ago

Type: Bug

When there is a reference to GitHub in the Copilot explanation, it is difficult to understand the link to the reference, and it disrupts reading with NVDA. See an example below. Explanation Context: This code snippet appears to be part of a method for constructing or configuring an object, possibly using a design pattern like Builder. Field tpHrio: .tpHrio(...): It is configuring the field tpHrio of the object being constructed.

VS Code version: Code 1.94.2 (384ff7382de624fb94dbaf6da11977bba1ecd427, 2024-10-09T16:08:44.566Z) OS version: Windows_NT x64 10.0.22631 Modes: Restricted

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-8365U CPU @ 1.60GHz (8 x 1896)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|31.72GB (20.14GB free)| |Process Argv|--crash-reporter-id 5391933d-2a30-4ca5-a5e4-b4571630ea33| |Screen Reader|yes| |VM|0%|
Extensions (11) Extension|Author (truncated)|Version ---|---|--- gitlens|eam|15.6.1 gc-excelviewer|Gra|4.2.62 azure-pipelines|ms-|1.247.2 python|ms-|2024.16.1 vscode-pylance|ms-|2024.10.1 remote-containers|ms-|0.389.0 remote-wsl|ms-|0.88.4 java|red|1.35.1 vscode-yaml|red|1.15.0 vscodeintellicode|Vis|1.3.1 vscode-maven|vsc|0.44.0
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805:30301674 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 vscaat:30438848 c4g48928:30535728 azure-dev_surveyonecf:30548226 962ge761:30959799 pythongtdpath:30769146 pythonnoceb:30805159 asynctok:30898717 pythonmypyd1:30879173 h48ei257:31000450 pythontbext0:30879054 accentitlementsc:30995553 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 724cj586:31013169 a69g1124:31058053 dvdeprecation:31068756 dwnewjupytercf:31046870 newcmakeconfigv2:31071590 impr_priority:31102340 nativerepl2:31139839 refactort:31108082 pythonrstrctxt:31112756 wkspc-onlycs-t:31132770 wkspc-ranged-t:31151552 cf971741:31144450 autoexpandse:31146404 iacca1:31156133 notype1:31157159 5fd0e150:31155592 iconenabled:31158251 ```
meganrogge commented 1 day ago

@jeanbrazcosta a gif would be helpful to understand where your cursor is and what your screen reader is saying at that time.

jeanbrazcosta commented 1 day ago

@meganrogge Sorry, I don't think there was an example of how the reader is reading when there is a reference link in the answer:

"command:_github.copilot.openSymbolFromReferences?%5B%22%22%2C%5B%7B%22uri%22%3A%7B%22scheme%22%3A%"

Note: In all links the reference appears as I mentioned in quotation marks above and it has been very difficult to read the responses:

To reproduce, open a code with several classes and ask a question, where the copilot references it with a link to facilitate the line in which he is explaining, the reader will read these characters and there are several of them for each link that is created.