microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.05k stars 29.22k forks source link

No close icon when Secondary Side Bar is on the right side of the editor region #232719

Open damisparks opened 6 days ago

damisparks commented 6 days ago

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

  1. Click the Copilot icon on the top bar on the right of the search bar to show the Secondary side bar.
  2. Position it on the right side of the editor region
  3. You should see there is no icon to close the Copilot Chat view. No close icon when Secondary Side Bar
gjsjohnmurray commented 6 days ago

I guess your Activity Bar position it set to 'top'.

The change I commented on at https://github.com/microsoft/vscode/issues/221129#issuecomment-2255712592 means in this case the Secondary Sidebar no longer has a Close button. Instead we are expected to use the toggle button in the group at the right-hand end of the titlebar.

Pinging @benibenj because the relocation of Copilot Chat is likely to mean more users encounter this.

damisparks commented 5 days ago

I guess your Activity Bar position it set to 'top'.

The change I commented on at #221129 (comment) means in this case the Secondary Sidebar no longer has a Close button. Instead we are expected to use the toggle button in the group at the right-hand end of the titlebar.

Pinging @benibenj because the relocation of Copilot Chat is likely to mean more users encounter this.

@gjsjohnmurray Your guess is right. My Activity Bar position is set to top.