microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.37k stars 29.32k forks source link

Purpose of `authentication` extension contribution point is unknown #233757

Open gjsjohnmurray opened 21 hours ago

gjsjohnmurray commented 21 hours ago

Type: Bug

The documentation at https://code.visualstudio.com/api/references/contribution-points omits the authentication contribution point, which is defined in authentication.contribution.ts.

The built-in github-authentication and microsoft-authentication extensions use it in their package.json files, and the schema for that file recognizes it as a valid entry of the contributes section.

However it is unclear how (if at all) an extension that registers an AuthenticationProvider benefits from declaring this in its package.json. I have published two such extensions, neither of which do this, yet both seem fully functional.

VS Code version: Code - Insiders 1.96.0-insider (399779942db4d7ab1bd6f6ae976482d0020f10ca, 2024-11-13T05:04:32.098Z) OS version: Windows_NT x64 10.0.22631 Modes:

gjsjohnmurray commented 21 hours ago

/assign @TylerLeonhardt

TylerLeonhardt commented 9 hours ago

You're correct. At this time, there really isn't a lot you get from declaring the contribution. The contribution really only provides these features at the moment:

I would like to change this and have this follow our other contribution stuff, however. Plus, maybe in the future we can provide an API that makes use of this or displays the providers somewhere (even if they have not yet been activated).