search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.8k stars 29.49k forks source link

escaping terminal chat / creating inline chat in the editor causes error #234596

Open meganrogge opened 2 days ago

meganrogge commented 2 days ago
  1. Run a few chat requests
  2. Hit escape

See this error in the console

 ERR TreeError [Chat] Tree element not found: [object Object]: Error: TreeError [Chat] Tree element not found: [object Object]
    at Jse.o (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:423:8336)
    at Jse.expandTo (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:423:7756)
    at Gk.reveal (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:423:2165)
    at VD.sb (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:717:26633)
    at VD.layout (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:717:38623)
    at $J.x (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1510:7627)
    at $J.layout (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1510:7434)
    at Het.P (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2505:6300)
    at Het.O (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2505:6030)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2505:5404
meganrogge commented 2 days ago

call to layout where the error is thrown happens before hide is called

https://github.com/user-attachments/assets/c337c121-5bcc-4045-91b6-6c0b377c35b0

meganrogge commented 2 days ago

the call to doLayout is coming from here , the call stack doesn't show what's causing that to happen when I hit close or escape

Image

meganrogge commented 2 days ago

@roblourens bisected to 32f6e84cfb15d14494ee259174172a95558b36b5 Image

meganrogge commented 2 days ago

also reproduces when I open chat in the editor

Image

meganrogge commented 2 days ago

maybe related #234595