search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.93k stars 29.52k forks source link

on terminal reconnection, `shellIntegration.cwd` is `undefined` #234672

Open meganrogge opened 6 days ago

meganrogge commented 6 days ago

discovered with terminal suggest https://github.com/microsoft/vscode/issues/234671

meganrogge commented 6 days ago

Also noticed that terminal is getting reconnected to even though there's been no input

https://github.com/user-attachments/assets/5fc84c60-4d09-4699-9f82-79cb7c283e4b

meganrogge commented 6 days ago

this doesn't get hit for the reconnected terminal

https://github.com/microsoft/vscode/blob/d7e34a7c8dab66edb16ed25b2a3b3b3876f1df38/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L456-L459

meganrogge commented 6 days ago

this doesn't either

https://github.com/microsoft/vscode/blob/d7e34a7c8dab66edb16ed25b2a3b3b3876f1df38/src/vs/platform/terminal/common/capabilities/cwdDetectionCapability.ts#L29

meganrogge commented 6 days ago

@Tyriar since you did most of the detached terminal and terminal capability store work, do you know where we set the capabilities for reconnected terminals?