keybinding's 'when' clause for 'view focused' and workbench's 'focus action' items for views are missing for some side bar views

[ar-daniel]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.95.3
• OS Version: linux mint mate 21.3

Version: 1.95.3 Commit: f1a4fb101478ce6ec82fe9627c43efbf9e98c813 Date: 2024-11-13T14:50:04.152Z Electron: 32.2.1 ElectronBuildId: 10427718 Chromium: 128.0.6613.186 Node.js: 20.18.0 V8: 12.8.374.38-electron.0 OS: Linux x64 5.15.0-126-generic

Issue

when setting keybindings, some action items and some relevant focus items for when clause are missing

List of when clause items missing ( so far found, not exhaustive )

• callstackFocused ( from Run & Debug section )
• outlineFocued ( from explorer section )
• timelineFocused ( from explorer section )
• searchResultListFocused ( from Search section of activity bar )
• extensionResultListFocused ( from extension section )

List of Focus action items missing, unable to bind keybindings ( so far found, not exhaustive )

• workbench.action.search.focusResultList
• workbench.action.search.focusSearchInputBox or search.action.focusSearchInputBox
• workbench.extensions.action.focusResultList
• workbench.extensions.action.focusSearchInputBox

the above command id naming were guessed for missing items, please improvise and provide the missing action and when clause items

Suggesting better support for keyboard navigation eg for side bar items, just like there is focus action and when clause for different views in sections of sidebar, focus action and when clause for view heading tabs and buttons located in tab for easier keyboard navigation to buttons in each view heading tab

Suggesting consistent naming for command-ids of workbench action items, when clauses focus for better clarity

just like workbench.files.action.focusOpenEditorsView,

• instead of 'timeline.focus' can have 'workbench.files.action.focusTimelineView'
• instead of 'outline.focus' can have 'workbench.files.action.focusOutlineView' or ''workbench.explorer.action.focusOutlineView', whichever meaningful
• instead of 'workbench.explorer.fileView.focus' can have 'workbench.explorer.action.focusFileView'

Implementing these will help with good keyboard navigation. Thank you

[benibenj]

I added focus context keys for the views you mentioned. Regarding the actions:

• workbench.action.search.focusResultList: We have search.action.focusSearchList
• workbench.action.search.focusSearchInputBox: We have workbench.view.search.focus
• workbench.extensions.action.focusResultList: Missing, we need a command @sandy081 workbench.extensions.action.focusExtensionsList
• workbench.extensions.action.focusSearchInputBox: We have workbench.extensions.action.focusExtensionsView

[ar-daniel]

1 regarding - workbench.view.search.focus - does not always focus the inputbox. Please see the following cases

• focuses either onto the searchInputBox or searchResultList, depending on which one was last focused; this is behaviour when the focus is on the following toggle buttons in the searchInput box or button for toggle search details or the 'Open in Editor' link

• and when the focus is on searchresultlist, then nothing happens as the focus is already in

also found searchViewletFocus is not true, when the focus is in either of toggle buttons in the searchInput box or button for toggle search details or the 'Open in Editor' link

workbench.view.search.active is true even when other activity sections are in view like the extensions view or the explorer view etc not sure whats the intended meaning of workbench.view.search.active

2 regarding - workbench.extensions.action.focusExtensionsView - when a extension is searched for and the extension result view is focused and now the action 'workbench.extensions.action.focusExtensionsView' is triggered the extension view gets reset, the extension input box is cleared and focus is set to inputbox

what is expected is to just transfer the focus to the extension's input box without clearing the text in the inputbox

I also initiated a feature request #234957, which could be useful in debugging such cases by users

3 Thanks for adding context keys/ when clauses, I found some more are also missing

• extension view focused
• extension search inputbox focused
• installed extensions focused

and action item - workbench.extensions.action.focusInstalledExtensions