All completions have the same icon

[jrieken]

Testing #235021

• trigger suggest
• notice all completions have the same icons, e.g files and commands are rendered the same

[Tyriar]

Some of this is following the lead of how powershell suggestions work where executables use the same icon as commands as that's essentially what they are. See calc.exe here coming from pwsh's TabExpansion2:

I'm on the fence here. Let's look at what other terminals do, how it's handled in the editor for the pwsh vscode extension, etc. Using just the file icon for install.sh might give the impression it's not going to do anything? Do we need a file icon with a badge? File theme support?

An issue I definitely do see is non-executable files being included so I created the more targeted https://github.com/microsoft/vscode/issues/235144.

[jrieken]

What's the value of icons if they are all the same? For cases like install.sh which is a file and executable I'd use the icon of the default action, when pressing enter on executable install.sh it runs and therefore is a command, if it lacks the exec-bit it just a filename (and should use the corresponding icon)

[Tyriar]

If it can't be executed though it shouldn't be in the list at all (https://github.com/microsoft/vscode/issues/235144). There are related concepts too like aliases and functions (cmdlets too on pwsh which are very similar). Hard to say how fine grained these should be exactly as the added value differentiating them in the icon is questionable.

[jrieken]

If it can't be executed though it shouldn't be in the list at all

Doesn't that mean I can't do chmod +x insta|<complete>?

[Tyriar]

@jrieken I'm talking purely about the command/first word suggestions here. chmod should still work as I think we fallback to file/folder completions in the current working directory when we're not sure what to do. Once we add a completion spec for it you should also get completions for the +x

[meganrogge]

I see unique icons here

[Tyriar]

@meganrogge the non-executable folders shouldn't be there, but relative executable files and folders make sense. ./scripts/code.sh|bat is a common thing I do but typing out just scri should show ./scripts too.