microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.58k stars 29.03k forks source link

How I can rename my theme extension #25988

Closed Binaryify closed 7 years ago

Binaryify commented 7 years ago

Hey, I am the 'OneDark-Pro' theme author, I rename this theme from 'Material Theme' to 'OneDark-Pro' recently. image

I change the 'package.json' info image

However, if I change the 'name', it will publish with a new theme and lose the downloads, if I don't change the 'name', the market site will show "ext install Material-theme" image

What should I do now?

seanmcbreen commented 7 years ago

Hi sorry I just saw this

The ID for an extension is publishername.extensionname all meta data hangs off this e.g. downloads, ratings. This is also used for install/updates.

In this case I actually think most users would expect this to be a new extension i.e. it's pretty different from Material.

So I think publishing with a new ID would make the most sense - otherwise users will get updated and not understand that this is actually a different theme.

We don't have support for renaming today - so choosing a new name is typically something people only do in the display name or again they are forced to re-publish :(

Sean