[1.12.1] editor.acceptSuggestionOnCommitCharacter not being respected

[scriptorum]

I'm working in C#. I like suggestions, but I never want Code to accept them without my explicit say so, such as the tab key. So I turned off acceptSuggestionOnCommitCharacter in my settings.json file:

But it still accepts the suggestion when I press . or ).

Am I misusing this setting?

• VSCode Version: Code 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b, 2017-05-04T21:18:32.269Z)
• OS Version: Darwin x64 16.5.0
• Extensions:

Extension	Author	Version
theme-glacier	Kal	0.0.1
uncrustify	LaurentTreguier	1.5.1
magoon	Northerntwig	1.1.0
theme-darktooth	Poorchop	0.0.2
unity-debug	Unity	1.1.0
nord-visual-studio-code	arcticicestudio	0.1.1
Theme-Monokai-Easylight	davidbabel	1.0.0
vs-code-xml-format	fabianlauer	0.1.5
Theme-Amy	gerane	0.0.2
Theme-Bliss	gerane	0.0.2
Theme-Brunette	gerane	0.0.4
Theme-Colonoscopy	gerane	0.0.2
Theme-Earthsong	gerane	0.0.2
Theme-FlatlandDark	gerane	0.0.2
Theme-Hail	gerane	0.0.3
Theme-monokai-inverse	gerane	0.0.2
theme-dusk	gllwy	0.0.7
theme-dark-starry-night	jerry	1.0.2
theme-onedark-sublime	joshpeng	0.3.6
FlatUI	lkytal	1.2.1
theme-chester	marcuskaz	0.1.1
cpptools	ms-vscode	0.10.5
csharp	ms-vscode	1.8.1
theme-whitehat	nisimiko	1.22.6
mac-classic-theme	nkjoep	0.0.1
theme-oceandeep	pierrenel	0.0.1
ClassyNaming	reflectiondm	1.0.0
vscode-format	ryannaddy	0.0.6
sblight	sbovyrin	2.1.1
dark-plus-material	vangware	1.0.0
gitflow	vector-of-bool	1.1.0
agila-theme	whtsky	2.0.1	;

---

Steps to Reproduce:

1. Turn off acceptSuggestionOnCommitCharacter
2. Type an identifier
3. Use . or ) to IGNORE the suggestion
4. Witness the suggestion being all like I'll do what I want you're not the boss of me

[jrieken]

@scriptorum Can you check if you have a keybinding for . or ) that is specific to C# and accepting a completion? Accept on commit used to be "implemented" with a keybinding

[scriptorum]

I see a binding to . under Keyboard Shortcuts: If I remove it then . no longer accepts suggestions. One down.

As for the closing paren, I don't see ) in Keyboard Shortcuts. Where would I find language-specific bindings?

[jrieken]

Where would I find language-specific bindings?

To right of this there should be a column when listing more information about this. It also contains the language for which it should be active

[scriptorum]

There it is. Filed under ⇧0 / ⇧9 instead of ./).

Removing these shortcuts restored the desired behavior. Thanks @jrieken!

[jrieken]

Thanks. I will follow up with the csharp-folks to use our improved story

[jrieken]

the issue on the omnisharp side: https://github.com/OmniSharp/omnisharp-vscode/issues/1487. closing this as a dupe of that one now