No next and previous keyboard shortcuts for Find widget in Integrated Terminal

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

163.05k stars 28.8k forks source link

No next and previous keyboard shortcuts for Find widget in Integrated Terminal #29661

Closed gregvanl closed 6 years ago

gregvanl commented 7 years ago

VSCode Version: 1.14 Insiders
OS Version: Windows 7

Steps to Reproduce:

Open Find widget and search for a string with several matches

There are no keyboard shortcuts for previous and next match (Shift + F3, F3).

gregvanl commented 7 years ago

Found during https://github.com/Microsoft/vscode/issues/29479

fabiospampinato commented 7 years ago

I agree that those actions should have the same shortcuts used in the editor's search widget bound to them, by default.

cleidigh commented 7 years ago

@Tyriar I will add these key bindings

cleidigh commented 7 years ago

Addressed by PR #31418

Tyriar commented 6 years ago

Reopening, https://github.com/Microsoft/vscode/pull/32113 didn't resolve

cleidigh commented 6 years ago

@Tyriar I have these functions from the summer work that was not merged. I can update and post a PR. Reminder : We also needed to add these to extension and mardown editors. I have this also.

Give me a thumbs up if this sounds good.

Tyriar commented 6 years ago

I think ideally F3/shift+F3 would work the same everywhere 👍