microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.73k stars 29.09k forks source link

Dim or otherwise indicate "inactive" editor/terminal #30522

Closed jasonhulbert closed 1 year ago

jasonhulbert commented 7 years ago

One of the best features of VS Code is the built-in terminal. However, I often begin typing in the editor when in fact I think I'm in the terminal - and vice versa. To alleviate this issue, it would be helpful to visually indicate which portion of the IDE is "active" vs. "inactive". A subtle dimming effect might just do the trick.

lobsterkatie commented 1 year ago

Yay! Thanks, @Tyriar, for taking our input!

abhijit-chikane commented 1 year ago

I just checked The issue with this is If I enable this setting and If I do some changes in editor and click on other file from the explorer it just move the focus from the editor

I don't think we want this behaviour I just care about the terminal and editor If I jump in between those then only it should inactive the corrosponding part but if it is going move the focus even if I click on the file explorer doesn't going to help much atleast for me @Tyriar

Tyriar commented 1 year ago

@abhijit-chikane I think you're asking for us to track whether the terminal or editor was focused last which is more state than I'd prefer to track for this feature. I'll wait for more feedback on the topic to see the reception as is first.

lobsterkatie commented 1 year ago

The issue with this is If I enable this setting and If I do some changes in editor and click on other file from the explorer it just move the focus from the editor

Oh, damn, I hadn't even thought of this. Yeah, that's not exactly how I was picturing it, either. That said, @abhijit-chikane, I think it's worth turning it on and living with it for a few weeks. It may turn out to be intuitive, or it may not. And if it's not, we can always open another feature request! 😛

Tyriar commented 1 year ago

and click on other file from the explorer it just move the focus from the editor

Also a little tip, you can double click to select the file in the explorer and focus the editor

Tyriar commented 1 year ago

FYI I'm planning on moving this back to live under accessibility., see https://github.com/microsoft/vscode/issues/191618 and some discussion about the feature in https://github.com/microsoft/vscode/issues/191610

Tyriar commented 1 year ago

There's been a bunch of feedback from the team during the test round. I'll be announcing the feature in the release notes' experimental section and this is the plan for upcoming improvements https://github.com/microsoft/vscode/issues/191775. Feedback is welcome of course!

lobsterkatie commented 1 year ago

There's been a bunch of feedback from the team during the test round.

I like your system of making an issue specifically for internal testing and then linked issues for feedback! I may suggest it to our product team. 🙂

Tyriar commented 1 year ago

@lobsterkatie this is our "endgame" week where the whole team turn into testers for a bit https://github.com/microsoft/vscode/wiki/Development-Process#end-game, it certainly works pretty well when building devtools 👍

lobsterkatie commented 1 year ago

Nice - I didn’t realize it was documented. Will definitely pass that along, thanks! And we do indeed make a devtool - you should check us out sometime!

Tyriar commented 1 year ago

@lobsterkatie ah I think I've heard ads for Sentry and been at the same conferences. I remember seeing https://blog.sentry.io/three-reasons-to-meat-us-at-github-universe/ 😉

lobsterkatie commented 1 year ago

Oh, how funny, and man, what a throwback! I remember the day our head of design was figuring out how to make the "Sentry" on that hot dog swag.

3DAB48DE-AD26-44B2-A627-21EB962F7456_1_105_c

In any case, we have an electron SDK as well as freestanding browser and node SDKs (which, full disclosure, I helped maintain for a few years) should y'all ever be interested. 🙂