onDidTerminateDebugSession asymmetry

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

164.17k stars 29.28k forks source link

onDidTerminateDebugSession asymmetry #31580

Closed jrieken closed 7 years ago

jrieken commented 7 years ago

testing #31475

We have onDidStartDebugSession and onDidTerminateDebugSession and I feel that start and terminate isn't a good couple. Maybe start and stop or launch and terminate?

weinand commented 7 years ago

we use the "Start" and "Terminate" antonyms because:

"Terminate" is the terminology from the Debug Adapter Protocol
"Start" (in favour of "launch") because "start" has to encompass both "launch" and "attach" modes. And using "launch" to start an "attach" configuration (as opposed to a "launch" configuration) is confusing.

I will not change anything here, but thanks for the suggestions.