search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.14k stars 28.53k forks source link

Icon: does not work well on Windows 7 #33337

Closed bpasero closed 6 years ago

bpasero commented 7 years ago

It looks like on Windows 10 the background of the taskbar is always black, so the log works better there. However, see Windows 7:

image

Even worse, the taskbar color is determined from the wallpaper, e.g.:

image

Or can be set directly (yes, where the gap is, the logo is):

image

Neme12 commented 7 years ago

Honestly, this could happen with any app that your background color will match the branding. This doesn't seem like an issue to me. You could always have a dark taskbar to let everything stand out. You can't set your taskbar to a bright shiny color and complain that it steals the focus from icons inside it.

bpasero commented 7 years ago

In my screenshot above, ALL other icons in the taskbar seem to work just fine across all taskbar backgrounds, only our new icon fails. So I would think we can do better.

DickvdBrink commented 7 years ago

In Windows 10 you can change the taskbar color, so you would have the same problem there.

Home > Personalization > Colors Change your accent color enable the "Start, taskbar and action center" checkbox under "Show accent color on the following surfaces"

If I make it blue my Edge color is hard to read, Green makes my Spotify icon a bit less clear so imo you can't really do the "right" thing for everyone when you have an icon with a single color

chrisdias commented 6 years ago

we've shipped the new icons, please see https://github.com/Microsoft/vscode/issues/6607#issuecomment-334600845