microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.5k stars 28.1k forks source link

Panel and viewlet on right should have a border between them #37373

Closed Tyriar closed 6 years ago

Tyriar commented 6 years ago
Extension Author (truncated) Version
EditorConfig Edi 0.11.1
lorem-ipsum Tyr 1.0.0
shell-launcher Tyr 0.1.4
vscode-terminal-here Tyr 0.0.5
vscode-svgviewer css 1.4.3
tslint eg2 1.0.14
git-project-manager fel 1.4.0
md-navigate jri 0.0.1
vscode-rust kal 0.4.2
vscode-scss mrm 0.6.2
cpptools ms- 0.14.0
seti-icons qin 0.1.3

(3 theme extensions excluded)


36906

Some themes separate the color of the workbench from the editor, if the panel and viewlet are the same color then it's hard to tell where the split is:

image

bpasero commented 6 years ago

I am not sure I would agree because this heavily depends on the theme, e.g. it is fine in dark theme:

image

In any case this probably needs a new theme color key. Note that we already (unfortunately) have panel.border which is for separating to the editor area. We probably need another key for separating to the side (only if the side bar is on the right actually).

image

isidorn commented 6 years ago

@bpasero agree this is theme dependent. Let's wait for users to complain before I introduce a new color and then we can allow themes to customize this.

isidorn commented 6 years ago

After looking deeper into this, we already have a color which does just this nicely "sideBar.border"

This issue in general is panel independent since the sidebar can have the same color as the editor and then the border is needed, which gets tackled by the above mentioned color.

Closing since this works nicely imho