microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.63k stars 29.04k forks source link

Empty sidebar. Files are not listed. #37693

Closed Sarav-S closed 6 years ago

Sarav-S commented 6 years ago
Extension Author (truncated) Version
crane Hvy 0.3.8
blockalign San 0.6.0
php-formatter Sop 0.2.4
php-debug fel 1.11.1
php-intellisense fel 1.5.1
phpcs ika 0.7.0
sublime-keybindings ms- 3.0.2
php-docblocker nei 1.3.0
laravel-blade one 1.10.0

Steps to Reproduce:

  1. File open folder -> chose my project folder
  2. I got empty sidebar with no files listed. Even ctrl + R/Recent project folder too didn't work.

Reproduces without extensions: Yes/No

roblourens commented 6 years ago

Does this happen with every folder or just a particular one?

Sarav-S commented 6 years ago

It happens with every folder. Trying to open projects with File->Open Recents or Ctrl+R also dint work out.

bpasero commented 6 years ago

@Sarav-S can you make sure to update to our lated 1.17 release.

Sarav-S commented 6 years ago

screen shot 2017-11-06 at 12 11 42 pm

I think I have the latest version @bpasero

bpasero commented 6 years ago

@Sarav-S can you share a screenshot how your files explorer in the sidebar looks like?

Sarav-S commented 6 years ago

screen shot 2017-11-06 at 12 21 12 pm

After adding folder through File->Open or File->Open Recents or Ctrl+R, I get only welcome screen.

Sarav-S commented 6 years ago

You can see my project title VSCode header. Actually the files are available when I do Cmd+P to open them. But it isn't available only on sidebar

bpasero commented 6 years ago

@sandy081 didn't we push a change so that the files explorer is never hidden?

@Sarav-S if you right click on the title of the explorer you should be able to bring back the files explorer properly.

Sarav-S commented 6 years ago

@bpasero I think explorer is open only except files are not listed. Please check screenshot.

screen shot 2017-11-06 at 12 32 31 pm

Sarav-S commented 6 years ago

@bpasero I have this same issue, except for Mac OS Sierra https://screencast-o-matic.com/watch/cbnt3w634b

bpasero commented 6 years ago

@Sarav-S do you see this context menu:

image

Sarav-S commented 6 years ago
screen shot 2017-11-06 at 2 48 53 pm

You mean this one?

sandy081 commented 6 years ago

Looks like we broke this in 1.17 while refactoring split view and views viewlet. And it is pretty bad.

Till 1.15 we were supporting toggling files explorer visibility. In 1.16 we took off that support #32962 here also making sure previous state is not considered. After refactoring we are no longer overriding the previous state.

I think this should be a candidate for 1.18 release.

sandy081 commented 6 years ago

Steps to reproduce:

Expected: File explorer is not shown and cannot be retrieved

Analysis: Looks like we broke this in 1.17 while refactoring split view and views viewlet. Till 1.15 we were supporting toggling files explorer visibility. In 1.16 we took off that support #32962 here also making sure previous state is not considered. After refactoring we are no longer overriding the previous state.

Impact: Low Users who had file explorer hidden in 1.15 release might not see file explorer and also cannot retrieve it after upgrading to latest version. Workaround is to upgrade to insiders containing the fix or clear cache for that folder as follows:

kapture 2017-11-06 at 12 54 24

Also, I only see 2 users filed this issue till now.

Sarav-S commented 6 years ago

@sandy081 Thanks! It worked :)

sandy081 commented 6 years ago

Reopening it for discussion for including it in October release or not.

roblourens commented 6 years ago

It is quite bad, and the fix looks simple, I think we should get it in for October.