Closed Sarav-S closed 6 years ago
Does this happen with every folder or just a particular one?
It happens with every folder. Trying to open projects with File->Open Recents or Ctrl+R also dint work out.
@Sarav-S can you make sure to update to our lated 1.17 release.
I think I have the latest version @bpasero
@Sarav-S can you share a screenshot how your files explorer in the sidebar looks like?
After adding folder through File->Open or File->Open Recents or Ctrl+R, I get only welcome screen.
You can see my project title VSCode header. Actually the files are available when I do Cmd+P to open them. But it isn't available only on sidebar
@sandy081 didn't we push a change so that the files explorer is never hidden?
@Sarav-S if you right click on the title of the explorer you should be able to bring back the files explorer properly.
@bpasero I think explorer is open only except files are not listed. Please check screenshot.
@bpasero I have this same issue, except for Mac OS Sierra https://screencast-o-matic.com/watch/cbnt3w634b
@Sarav-S do you see this context menu:
You mean this one?
Looks like we broke this in 1.17 while refactoring split view and views viewlet. And it is pretty bad.
Till 1.15 we were supporting toggling files explorer visibility. In 1.16 we took off that support #32962 here also making sure previous state is not considered. After refactoring we are no longer overriding the previous state.
I think this should be a candidate for 1.18 release.
Steps to reproduce:
Expected: File explorer is not shown and cannot be retrieved
Analysis: Looks like we broke this in 1.17 while refactoring split view and views viewlet. Till 1.15 we were supporting toggling files explorer visibility. In 1.16 we took off that support #32962 here also making sure previous state is not considered. After refactoring we are no longer overriding the previous state.
Impact: Low Users who had file explorer hidden in 1.15 release might not see file explorer and also cannot retrieve it after upgrading to latest version. Workaround is to upgrade to insiders containing the fix or clear cache for that folder as follows:
Developer: Toggle Developer Tools
file://
under Local Storage
section in the menu on the leftworkbench.explorer.views.state
using Filter inputboxAlso, I only see 2 users filed this issue till now.
@sandy081 Thanks! It worked :)
Reopening it for discussion for including it in October release or not.
It is quite bad, and the fix looks simple, I think we should get it in for October.
Steps to Reproduce:
Reproduces without extensions: Yes/No