search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.13k stars 28.52k forks source link

"Go to Definition" broken in last update OSX version #3880

Closed contreras-jorgev closed 8 years ago

contreras-jorgev commented 8 years ago

Editing node.js (JavaScript) files (after opening a folder), where a file requires another module (same folder), if you want to see the definition of a symbol (F12 or right-lick "Go to Definition") stopped working with latest update Version 0.10.10 (0.10.10)

I use this feature frequently. It used to work fine.

alexwarren commented 8 years ago

I'm seeing the same issue here (editing code at https://github.com/textadventures/quest/tree/v6/Player). It worked fine before the update.

I'm using requirejs. I tried adding a jsconfig.js file, setting module to amd, but that didn't help.

egamma commented 8 years ago

@contreras-jorgev I you have no jsconfig.json for your project then this is a duplicate of: Microsoft/TypeScript#7292

egamma commented 8 years ago

@alexwarren I'm sorry, but amd module resolution is currently not supported by Salsa. Duplicate of https://github.com/Microsoft/TypeScript/issues/6942

contreras-jorgev commented 8 years ago

Just to clarify, since you closed the issue: after the move to Salsa, module resolution while working with node.js modules will not work? (I am not familiar with amd )

This may be a show stopper for me. I was so happy with VS Code, I may need to go back to SublimeText

On Thu, Mar 10, 2016 at 3:32 AM, Erich Gamma notifications@github.com wrote:

Closed #3880 https://github.com/Microsoft/vscode/issues/3880.

— Reply to this email directly or view it on GitHub https://github.com/Microsoft/vscode/issues/3880#event-584593251.

egamma commented 8 years ago

@contreras-jorgev Sorry, I wasn't clear Salsa fully supports node module resolution and it is more robust than it was before. Commonjs is the default module type, but I still recommend that you create a jsconfig.json, then you can easily leverage .d.ts files to get Intellisense for existing node modules. Pls see https://code.visualstudio.com/docs/runtimes/nodejs.