microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.99k stars 29.19k forks source link

Visual Stodio Code 1.19.2 crashing on MacOS High Sierra when variable NEXT_ROOT is defined #42148

Closed planetwebmethods closed 5 years ago

planetwebmethods commented 6 years ago

Steps to Reproduce:

  1. Open the Application
  2. It crashes on startup

Does this issue occur when all extensions are disabled?: Yes

Mac Report Issue Error Report

Process: Electron [4508] Path: /Applications/Visual Studio Code.app/Contents/MacOS/Electron Identifier: com.microsoft.VSCode Version: 1.19.2 (1.19.2) Code Type: X86-64 (Native) Parent Process: ??? [1] Responsible: Electron [4508] User ID: 227143951

Date/Time: 2018-01-25 16:26:10.918 +0530 OS Version: Mac OS X 10.13.2 (17C205) Report Version: 12 Bridge OS Version: 3.0 (14Y661) Anonymous UUID: 99DB5E4B-E631-275E-A0E1-D459EBBE2AF4

Time Awake Since Boot: 16000 seconds

System Integrity Protection: enabled

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_BAD_INSTRUCTION (SIGILL) Exception Codes: 0x0000000000000001, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY

Termination Signal: Illegal instruction: 4 Termination Reason: Namespace SIGNAL, Code 0x4 Terminating Process: exc handler [0]

Application Specific Information: Crashing on exception: Critical error: required built-in appearance SystemAppearance not found

planetwebmethods commented 6 years ago

image

bpasero commented 6 years ago

@planetwebmethods Can you please follow the steps in https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues to get at more details around the crash and attach the result here? Thanks!

nalcalde commented 6 years ago

Hi,

My VSC 1.19.2 also crashed in MAC High Sierra:

Code Helper_2018-01-25-143729_C02RJ64GG8WN.crash.zip

Thanks, Naldo

bpasero commented 6 years ago

@nalcalde any steps that leads to your crash?

planetwebmethods commented 6 years ago

I have already pasted it the issue. It looks the same as the one that Naldo attached.

planetwebmethods commented 6 years ago

I was able to resolve the issue.... But that's a temporary fix for me.

on terminal issue the command

unset NEXT_ROOT

Then starting code works fine. Looks like this environment variable is causing issues.

Thanks Ashish

bpasero commented 6 years ago

Yeah seems to be the same issue as https://github.com/Microsoft/vscode/issues/21931

bpasero commented 6 years ago

@planetwebmethods @nalcalde do you get this crash when you run the app from the dock or only when you run from the command line?

planetwebmethods commented 6 years ago

I get it both ways

Thanks Ashish

planetwebmethods commented 6 years ago

Do we have nay updates on this???? Its killing my time

planetwebmethods commented 6 years ago

Another update:

After doing unset NEXT_ROOT, Code still does not open if I open from Spotlight/Launchpad/ Applications

It does open fine if I open from Terminal.

nalcalde commented 6 years ago

Crashes in both ways: command line and dock.

unset NEXT_ROOT not works for me.

nalcalde commented 6 years ago

Hi guys,

I figure out that installed icon of VSC not works, but launching by command line works!

"/Applications/Visual Studio Code.app/Contents/Resources/app/bin/code"

Enjoy it.

Regards, Naldo

ragnar-pwninskjold commented 6 years ago

unset NEXT_ROOT worked for me High Sierra 10.13.3

planetwebmethods commented 6 years ago

Yes that works. But you will need to open it every time from terminal.

---- On Fri, 23 Mar 2018 00:42:56 +0530 notifications@github.com wrote ----

unset NEXT_ROOT worked for me High Sierra 10.13.3

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

retrorism commented 6 years ago

This is probably a separate issue, but if there's anyone else here who landed here after experiencing a (seemingly) unbreakable 'A window/tab crashed before, what now? Reopen / Don't Reopen' crash loop in Mac OSX High Sierra: for me the solution turned out to be deleting the following folder: ~/Library/Saved Application State/com.microsoft.VSCode.savedState

atljoseph commented 5 years ago

Jesus Christ this is annoying, VS Code

bpasero commented 5 years ago

/duplicate https://github.com/electron/electron/issues/20477

vscodebot[bot] commented 5 years ago

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!