microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.63k stars 29.04k forks source link

Find in folder doesn't work #46319

Closed silverphoenix1110 closed 6 years ago

silverphoenix1110 commented 6 years ago

Issue Type: Bug

"Find in folder" doesn't work. It just find in files, which are opening, not with all files in the folder

VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:47:13.351Z) OS version: Windows_NT ia32 10.0.16299

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz (8 x 2712)| |Memory (System)|15.60GB (7.29GB free)| |Process Argv|C:\Program Files (x86)\Microsoft VS Code\Code.exe| |Screen Reader|no| |VM|33%|
Extensions (30) Extension|Author (truncated)|Version ---|---|--- project-manager|ale|0.25.0 alignment|ann|0.3.0 scanner-js-twain-wia-javascript-browser-scan|asp|2.0.2 vscode-database|baj|1.5.1 path-intellisense|chr|1.4.2 open-html-in-browser|cod|0.1.21 compulim-vscode-dictionary|Com|0.0.5 cake-cored|Crh|1.1.2 vue-peek|dar|1.0.2 githistory|don|0.4.0 jquerysnippets|don|0.0.1 gitlens|eam|8.1.1 php-intellisense|fel|2.3.0 auto-close-tag|for|0.5.6 auto-rename-tag|for|0.0.15 code-runner|for|0.9.3 vue-snippets|hol|0.1.5 beautify|Hoo|1.3.0 minify|Hoo|0.3.0 html-tag-wrapper|hwe|0.2.3 sftp|lix|1.1.4 Go|luk|0.6.77 sqltools|mtx|0.12.1 php-docblocker|nei|1.3.3 vetur|oct|0.11.7 vscode-code-outline|pat|0.0.13 subtle-brackets|raf|2.1.0 pdf|tom|0.2.0 vscode-wakatime|Wak|1.1.26 change-case|wma|1.0.0 (1 theme extensions excluded)

Reproduces only with extensions

vscodebot[bot] commented 6 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

roblourens commented 6 years ago

Does it work when a different folder is open?

Are the missing files covered by search.exclude settings or .gitignore files?

silverphoenix1110 commented 6 years ago

Hi, @roblourens There aren't missing files covered by search.exclude settings or .gitignore files. It works when a different folder is open. This bug sometimes happens, not always. As I see, It happens when I using "split editors" and close other files

roblourens commented 6 years ago

It works when a different folder is open.

If so, are you sure there aren't exclude settings involved? Can you think of any other difference between the two folders? You can double check by toggling off the "Use Exclude Settings and Ignore Files" button (bottom right)

image

camflint commented 6 years ago

I can reproduce this issue consistently within a workspace. Only files that are opened are searched, instead of the expected behavior of all files on disk within the search scope. The exclude filter and "search.exclude" are not involved. Turning ripgrep on/off does not make a difference.

Version 1.21.1
Commit 79b44aa704ce542d8ca4a3cc44cfca566e7720f1
Date 2018-03-14T14:46:47.128Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
roblourens commented 6 years ago

Can both of you try downloading the Insiders' build and tell me whether it happens there? https://code.visualstudio.com/insiders

vscodebot[bot] commented 6 years ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!