Command cmd P no longer finds files

joshunger commented 6 years ago

Issue Type: Bug

Command P (cmd p) no longer finds file / or indexes them correctly? In the picture below chrome-drive.js should appear in the results.

VS Code version: Code - Insiders 1.23.0-insider (b845ce918f2689344795e845ae6ef691916c3079, 2018-04-24T05:10:57.500Z) OS version: Darwin x64 17.5.0

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 2| |Memory (System)|16.00GB (0.02GB free)| |Process Argv|/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron ./| |Screen Reader|no| |VM|0%|

Extensions (11)

Extension|Author (truncated)|Version ---|---|--- sort-lines|Tyr|1.6.1 vscode-eslint|dba|1.4.8 prettier-vscode|esb|1.3.1 flow-for-vscode|flo|0.8.0 python|ms-|2018.3.1 java|red|0.23.0 vscode-fileutils|sle|2.8.1 vscode-java-debug|vsc|0.9.0 vscode-java-pack|vsc|0.3.0 vscode-java-test|vsc|0.5.0 vscode-maven|vsc|0.7.0

roblourens commented 6 years ago

Did it work before?
Are the missing results covered by a .gitignore or pattern from search.exclude or files.exclude?
Does it happen in every folder, or just one particular folder?

joshunger commented 6 years ago

Yes.
I don't think so. This is the project I had open - https://github.com/devtools-html/devtools-core/
Maybe any subfolder?

How do you troubleshoot? This must be a machine specific issue if you're not seeing it?

roblourens commented 6 years ago

I don't think so. This is the project I had open - devtools-html/devtools-core

It works for me in that project, but also check your user settings for exclude settings.

Maybe any subfolder?

I mean, does it work with other projects/folders on your computer?

Please try this to see logs:

Run the command "Set log level" and change it to "Trace"
Try quickopen again
Show all the search-related messages in the "Log (Window)" output panel

joshunger commented 6 years ago

It works intermittently on projects. On the projects that don't work, it appears to only find files in the root folder. This might be multiple issues. Is there a Slack channel I can ask questions to instead of bugging you over issue comments? In another scenario, it can't find files under a directory called foo.war.

joshunger commented 6 years ago

roblourens commented 6 years ago

Can you show more of the log? Looking for a line that starts with SearchService#search rg --files ... and also any errors around that.

Also can you check for errors in the developer tools? (Help > toggle developer tools)

Issue comments are fine

joshunger commented 6 years ago

[2018-04-30 06:49:12.690] [renderer1] [trace] CommandService#executeCommand workbench.action.quickOpen
[2018-04-30 06:49:12.693] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"","maxResults":0,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:12.718] [renderer1] [debug] SearchService#search rg --files --hidden --case-sensitive -g '!**/.git' -g '!**/.svn' -g '!**/.hg' -g '!**/CVS' -g '!**/.DS_Store' -g '!**/node_modules' -g '!**/bower_components' --no-ignore-parent --follow -- '.'
 - cwd: /Users/junger/dev/devtools-core
 - Sibling clauses: {}
[2018-04-30 06:49:14.240] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"c","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:14.339] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"ch","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:14.457] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chr","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:14.541] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chro","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:14.614] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrom","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:14.694] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:14.849] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:14.966] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-d","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:15.167] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-dr","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:15.343] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-dri","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:15.449] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-driv","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:15.651] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-drive","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:15.794] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-driver","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:15.889] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-driver.","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:16.062] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-driver.j","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}
[2018-04-30 06:49:16.168] [renderer1] [trace] SearchService#search {"type":1,"folderQueries":[{"folder":{"$mid":1,"fsPath":"/Users/junger/dev/devtools-core","external":"file:///Users/junger/dev/devtools-core","path":"/Users/junger/dev/devtools-core","scheme":"file"},"excludePattern":{"**/.git":true,"**/.svn":true,"**/.hg":true,"**/CVS":true,"**/.DS_Store":true,"**/node_modules":true,"**/bower_components":true},"fileEncoding":"utf8","disregardIgnoreFiles":false}],"usingSearchPaths":false,"filePattern":"chrome-driver.js","maxResults":512,"sortByScore":true,"cacheKey":"id#50","contentPattern":null,"useRipgrep":true,"disregardIgnoreFiles":false,"ignoreSymlinks":false}

joshunger commented 6 years ago

No errors. Thanks for the help.

roblourens commented 6 years ago

Does text search return results when quickopen isn't working?

joshunger commented 6 years ago

No, text search does not return results. :(

roblourens commented 6 years ago

I'm confused. Can you try invoking the rg command manually in a terminal? From the log,

rg --files --hidden --case-sensitive -g '!**/.git' -g '!**/.svn' -g '!**/.hg' -g '!**/CVS' -g '!**/.DS_Store' -g '!**/node_modules' -g '!**/bower_components' --no-ignore-parent --follow -- '.'

except change rg to the real path to the binary which should be something like /Applications/Visual\ Studio\ Code\ -\ Insiders.app/Contents/Resources/app/node_modules.asar.unpacked/vscode-ripgrep/bin/rg

roblourens commented 6 years ago

Also, have you tried Stable just to see if there's a difference?

joshunger commented 6 years ago

Same issue on stable.

roblourens commented 6 years ago

Can you try invoking the rg command manually to see if it errors or produces valid output? See a couple comments up.

joshunger commented 6 years ago

Ignore command text Hyper doesn't copy well

🐹 $
~/dev/devtools-core
-files --hidden --case-sensitive -g '!**/.git' -g '!**/.svn' -g '!**/.hg' -g '!**/CVS' -g '!**/.DS_Store' -g '!**/node_modules' -g '!**/bower_components' --no-ignore-parent --follow -- '.'
.eslintrc
.editorconfig
.stylelintignore
README.md
.stylelintrc
yarn.lock
.gitignore
package.json
circle.yml
.eslintignore
.flowconfig
lerna.json
docs/versioning.md
docs/local-development.md
flow-typed/debugger-html.js
.github/PULL_REQUEST_TEMPLATE
~/dev/devtools-core
🐷 $

I wonder if my machine is messed up? :(

roblourens commented 6 years ago

So it's missing everything under packages? Can you try simplifying the arguments or throwing in a --no-ignore just to make sure it didn't end up in your .gitignore?

Can you get files that it does return in quickopen?

joshunger commented 6 years ago

Good catch! For some reason I have a rogue .gitignore at ~/. I opened code under ~/dev/devtools-core as the root. ~/ is not a git repository. Thanks for the help. What would you like to do with this bug?

# Created by .ignore support plugin (hsz.mobi)
### Android template
# Built application files
*.apk
*.ap_

# Files for the Dalvik VM
*.dex

# Java class files
*.class

# Generated files
bin/
gen/

# Gradle files
.gradle/
build/
/*/build/

# Local configuration file (sdk path, etc)
local.properties

# Proguard folder generated by Eclipse
proguard/

# Log Files
*.log

### js template
.idea/
atlassian-connector.xml
target/
.tmp/
tmp/
temp/
node_modules/
bower_components/

### Eclipse template
*.pydevproject
.metadata
.gradle
bin/
tmp/
*.tmp
*.bak
*.swp
*~.nib
local.properties
.settings/
.loadpath

# Eclipse Core
.project

# External tool builders
.externalToolBuilders/

# Locally stored "Eclipse launch configurations"
*.launch

# CDT-specific
.cproject

# JDT-specific (Eclipse Java Development Tools)
.classpath

# PDT-specific
.buildpath

# sbteclipse plugin
.target

# TeXlipse plugin
.texlipse

### SublimeText template
# cache files for sublime text
*.tmlanguage.cache
*.tmPreferences.cache
*.stTheme.cache

# workspace files are user-specific
*.sublime-workspace

# project files should be checked into the repository, unless a significant
# proportion of contributors will probably not be using SublimeText
# *.sublime-project

# sftp configuration file
sftp-config.json

.tm_properties
### Node template
# Logs
logs
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (https://nodejs.org/api/addons.html)
build/Release

# Dependency directories
jspm_packages/

# Typescript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env

# next.js build output
.next
### Linux template
*~

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*
### Xcode template
# Xcode
#
# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore

## User settings
xcuserdata/

## compatibility with Xcode 8 and earlier (ignoring not required starting Xcode 9)
*.xcscmblueprint
*.xccheckout

## compatibility with Xcode 3 and earlier (ignoring not required starting Xcode 4)
DerivedData/
*.moved-aside
*.pbxuser
!default.pbxuser
*.mode1v3
!default.mode1v3
*.mode2v3
!default.mode2v3
*.perspectivev3
!default.perspectivev3
### JetBrains template
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and Webstorm
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

# User-specific stuff:
.idea/**/workspace.xml
.idea/**/tasks.xml
.idea/dictionaries

# Sensitive or high-churn files:
.idea/**/dataSources/
.idea/**/dataSources.ids
.idea/**/dataSources.xml
.idea/**/dataSources.local.xml
.idea/**/sqlDataSources.xml
.idea/**/dynamic.xml
.idea/**/uiDesigner.xml

# Gradle:
.idea/**/gradle.xml
.idea/**/libraries

# CMake
cmake-build-debug/
cmake-build-release/

# Mongo Explorer plugin:
.idea/**/mongoSettings.xml

## File-based project format:
*.iws

## Plugin-specific files:

# IntelliJ
out/

# mpeltonen/sbt-idea plugin
.idea_modules/

# JIRA plugin
atlassian-ide-plugin.xml

# Cursive Clojure plugin
.idea/replstate.xml

# Crashlytics plugin (for Android Studio and IntelliJ)
com_crashlytics_export_strings.xml
crashlytics.properties
crashlytics-build.properties
fabric.properties
### Yeoman template

dist/
### macOS template
# General
.DS_Store
.AppleDouble
.LSOverride

# Icon must end with two \r
Icon

# Thumbnails
._*

# Files that might appear in the root of a volume
.DocumentRevisions-V100
.fseventsd
.Spotlight-V100
.TemporaryItems
.Trashes
.VolumeIcon.icns
.com.apple.timemachine.donotpresent

# Directories potentially created on remote AFP share
.AppleDB
.AppleDesktop
Network Trash Folder
Temporary Items
.apdisk
### Java template
# Compiled class file

# Log file

# BlueJ files
*.ctxt

# Mobile Tools for Java (J2ME)
.mtj.tmp/

# Package Files #
*.jar
*.war
*.ear
*.zip
*.tar.gz
*.rar

# virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml
hs_err_pid*
### SublimeText template
# Cache files for Sublime Text

# Workspace files are user-specific

# Project files should be checked into the repository, unless a significant
# proportion of contributors will probably not be using Sublime Text
# *.sublime-project

# SFTP configuration file

# Package control specific files
Package Control.last-run
Package Control.ca-list
Package Control.ca-bundle
Package Control.system-ca-bundle
Package Control.cache/
Package Control.ca-certs/
Package Control.merged-ca-bundle
Package Control.user-ca-bundle
oscrypto-ca-bundle.crt
bh_unicode_properties.cache

# Sublime-github package stores a github token in this file
# https://packagecontrol.io/packages/sublime-github
GitHub.sublime-settings
### VisualStudio template
## Ignore Visual Studio temporary files, build results, and
## files generated by popular Visual Studio add-ons.
##
## Get latest from https://github.com/github/gitignore/blob/master/VisualStudio.gitignore

# User-specific files
*.suo
*.user
*.userosscache
*.sln.docstates

# User-specific files (MonoDevelop/Xamarin Studio)
*.userprefs

# Build results
[Dd]ebug/
[Dd]ebugPublic/
[Rr]elease/
[Rr]eleases/
x64/
x86/
bld/
[Bb]in/
[Oo]bj/
[Ll]og/

# Visual Studio 2015/2017 cache/options directory
.vs/
# Uncomment if you have tasks that create the project's static files in wwwroot
#wwwroot/

# Visual Studio 2017 auto generated files
Generated\ Files/

# MSTest test Results
[Tt]est[Rr]esult*/
[Bb]uild[Ll]og.*

# NUNIT
*.VisualState.xml
TestResult.xml

# Build Results of an ATL Project
[Dd]ebugPS/
[Rr]eleasePS/
dlldata.c

# Benchmark Results
BenchmarkDotNet.Artifacts/

# .NET Core
project.lock.json
project.fragment.lock.json
artifacts/
**/Properties/launchSettings.json

# StyleCop
StyleCopReport.xml

# Files built by Visual Studio
*_i.c
*_p.c
*_i.h
*.ilk
*.meta
*.obj
*.pch
*.pdb
*.pgc
*.pgd
*.rsp
*.sbr
*.tlb
*.tli
*.tlh
*.tmp_proj
*.vspscc
*.vssscc
.builds
*.pidb
*.svclog
*.scc

# Chutzpah Test files
_Chutzpah*

# Visual C++ cache files
ipch/
*.aps
*.ncb
*.opendb
*.opensdf
*.sdf
*.cachefile
*.VC.db
*.VC.VC.opendb

# Visual Studio profiler
*.psess
*.vsp
*.vspx
*.sap

# Visual Studio Trace Files
*.e2e

# TFS 2012 Local Workspace
$tf/

# Guidance Automation Toolkit
*.gpState

# ReSharper is a .NET coding add-in
_ReSharper*/
*.[Rr]e[Ss]harper
*.DotSettings.user

# JustCode is a .NET coding add-in
.JustCode

# TeamCity is a build add-in
_TeamCity*

# DotCover is a Code Coverage Tool
*.dotCover

# AxoCover is a Code Coverage Tool
.axoCover/*
!.axoCover/settings.json

# Visual Studio code coverage results
*.coverage
*.coveragexml

# NCrunch
_NCrunch_*
.*crunch*.local.xml
nCrunchTemp_*

# MightyMoose
*.mm.*
AutoTest.Net/

# Web workbench (sass)
.sass-cache/

# Installshield output folder
[Ee]xpress/

# DocProject is a documentation generator add-in
DocProject/buildhelp/
DocProject/Help/*.HxT
DocProject/Help/*.HxC
DocProject/Help/*.hhc
DocProject/Help/*.hhk
DocProject/Help/*.hhp
DocProject/Help/Html2
DocProject/Help/html

# Click-Once directory
publish/

# Publish Web Output
*.[Pp]ublish.xml
*.azurePubxml
# Note: Comment the next line if you want to checkin your web deploy settings,
# but database connection strings (with potential passwords) will be unencrypted
*.pubxml
*.publishproj

# Microsoft Azure Web App publish settings. Comment the next line if you want to
# checkin your Azure Web App publish settings, but sensitive information contained
# in these scripts will be unencrypted
PublishScripts/

# NuGet Packages
*.nupkg
# The packages folder can be ignored because of Package Restore
**/[Pp]ackages/*
# except build/, which is used as an MSBuild target.
!**/[Pp]ackages/build/
# Uncomment if necessary however generally it will be regenerated when needed
#!**/[Pp]ackages/repositories.config
# NuGet v3's project.json files produces more ignorable files
*.nuget.props
*.nuget.targets

# Microsoft Azure Build Output
csx/
*.build.csdef

# Microsoft Azure Emulator
ecf/
rcf/

# Windows Store app package directories and files
AppPackages/
BundleArtifacts/
Package.StoreAssociation.xml
_pkginfo.txt
*.appx

# Visual Studio cache files
# files ending in .cache can be ignored
*.[Cc]ache
# but keep track of directories ending in .cache
!*.[Cc]ache/

# Others
ClientBin/
~$*
*.dbmdl
*.dbproj.schemaview
*.jfm
*.pfx
*.publishsettings
orleans.codegen.cs

# Including strong name files can present a security risk
# (https://github.com/github/gitignore/pull/2483#issue-259490424)
#*.snk

# Since there are multiple workflows, uncomment next line to ignore bower_components
# (https://github.com/github/gitignore/pull/1529#issuecomment-104372622)
#bower_components/

# RIA/Silverlight projects
Generated_Code/

# Backup & report files from converting an old project file
# to a newer Visual Studio version. Backup files are not needed,
# because we have git ;-)
_UpgradeReport_Files/
Backup*/
UpgradeLog*.XML
UpgradeLog*.htm

# SQL Server files
*.mdf
*.ldf
*.ndf

# Business Intelligence projects
*.rdl.data
*.bim.layout
*.bim_*.settings

# Microsoft Fakes
FakesAssemblies/

# GhostDoc plugin setting file
*.GhostDoc.xml

# Node.js Tools for Visual Studio
.ntvs_analysis.dat

# TypeScript v1 declaration files

# Visual Studio 6 build log
*.plg

# Visual Studio 6 workspace options file
*.opt

# Visual Studio 6 auto-generated workspace file (contains which files were open etc.)
*.vbw

# Visual Studio LightSwitch build output
**/*.HTMLClient/GeneratedArtifacts
**/*.DesktopClient/GeneratedArtifacts
**/*.DesktopClient/ModelManifest.xml
**/*.Server/GeneratedArtifacts
**/*.Server/ModelManifest.xml
_Pvt_Extensions

# Paket dependency manager
.paket/paket.exe
paket-files/

# FAKE - F# Make
.fake/

# JetBrains Rider
*.sln.iml

# CodeRush
.cr/

# Python Tools for Visual Studio (PTVS)
__pycache__/
*.pyc

# Cake - Uncomment if you are using it
# tools/**
# !tools/packages.config

# Tabs Studio
*.tss

# Telerik's JustMock configuration file
*.jmconfig

# BizTalk build output
*.btp.cs
*.btm.cs
*.odx.cs
*.xsd.cs

# OpenCover UI analysis results
OpenCover/

# Azure Stream Analytics local run output
ASALocalRun/

# MSBuild Binary and Structured Log
*.binlog

### Kotlin template
# Compiled class file

# Log file

# BlueJ files

# Mobile Tools for Java (J2ME)

# Package Files #

# virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml

roblourens commented 6 years ago

So that's interesting because this is exactly what the --no-ignore-parent flag is supposed to prevent. It should keep rg from looking upwards for gitignore files. Can you try to narrow down the rg command to see if it's simply not working on your machine?

I set up this exact scenario with the same .gitignore file and can't repro it.

Thanks for all the debugging help so far.

joshunger commented 6 years ago

I ran out of time to help this week sorry @roblourens

brocoli commented 6 years ago

I caught Cmd + P failing to find files in my own project intermittently on occasion.

Also, is there a way to disable the .gitignore parsing? I often need to jump to files inside node_modules to check their implementation, and right now Cmd + P doesn't help with that because it respects .gitignore :/

(and navigating to the package inside the stupidly bloated node_modules takes a long time)

I'd rather tell it to ignore specific folders and files, and also folders and files that start with . manually.

roblourens commented 6 years ago

@brocoli open a new issue if we need to investigate. You can disable .gitignore checking with "search.useIgnoreFiles": false.

vscodebot[bot] commented 6 years ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

joshunger commented 6 years ago

@roblourens do you personally know vscodebot? He closed the issue. ;) Do you want to keep this closed?

roblourens commented 6 years ago

If you have any time to experiment with running that rg command to figure out why --no-ignore-parent isn't working in this case, I'd appreciate it and will keep this open. It's a strange bug that nobody else has reported so I can't do much on my end.

And if the bug just seems to be that flag not working, you could run the rg command with --debug and open an issue upstream on https://github.com/BurntSushi/ripgrep.

joshunger commented 6 years ago

@roblourens I logged https://github.com/BurntSushi/ripgrep/issues/934 $HOME/.gitignore is incorrectly used when searching in other directories such as /tmp

roblourens commented 6 years ago

Thanks!

roblourens commented 6 years ago

tldr: ripgrep was using the global config of core.excludesfile=~/.gitignore.

Now --no-ignore-global exists to prevent it from checking that config option and vscode should set that flag.

Need to update the ripgrep version.

roblourens commented 6 years ago

Verification:

Set a global gitignore file like git config --global core.excludesfile ~/.gitignore_global
Add a pattern to that global gitignore file that matches some files in your workspace
Do a text search in vscode and verify that the global gitignore is not applied you can still find matches in those files

chrmarti commented 6 years ago

Still an issue with QuickOpen, we need to add that argument there too.

chrmarti commented 6 years ago

Maybe also include --no-config.

roblourens commented 6 years ago

Good catch, thanks!

microsoft / vscode

Command cmd P no longer finds files #48771