microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.63k stars 29.04k forks source link

Newly published theme can not be activated #49224

Closed swashata closed 6 years ago

swashata commented 6 years ago

Issue Type: Bug

Hi,

I created and published a new color theme set.

The repo can be found here: https://github.com/swashata/vscode-beautiful-ui The published one is here: https://marketplace.visualstudio.com/items?itemName=swashata.beautiful-ui

I have since deleted the extension from ~/.vscode/extensions directory and restarted VSCode.

Now when I install the extension from inside vscode (Extensions > Search 'beautiful ui') it installs fine, but the reload button never goes away, even after restarting vscode several times.

Also the color themes are never found in the command palette.

VS Code version: Code 1.23.0 (7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45, 2018-05-03T15:23:14.634Z) OS version: Darwin x64 17.5.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 3| |Memory (System)|8.00GB (0.22GB free)| |Process Argv|/Applications/Visual Studio Code.app/Contents/MacOS/Electron| |Screen Reader|no| |VM|0%|
Extensions (30) Extension|Author (truncated)|Version ---|---|--- EditorConfig|Edi|0.12.1 vscode-paste-and-indent|Rub|0.0.8 snapshot-tools|asv|0.0.7 vscode-intelephense-client|bme|0.8.8 npm-intellisense|chr|1.3.0 woocommerce|cla|1.0.0 wpcs-whitelist-flags|cla|1.0.0 gitignore|cod|0.5.0 vscode-eslint|dba|1.4.8 prettier-vscode|esb|1.3.1 vscode-diff|fab|1.3.2 php-debug|fel|1.12.3 rest-client|hum|0.18.4 phpcs|ika|1.0.5 path-autocomplete|ion|1.9.0 vs-code-phpunit-snippets|jam|0.0.2 docthis|joe|0.6.0 vscode-colorize|kam|0.6.18 dotenv|mik|1.0.1 ecdc|mit|0.12.0 sublime-keybindings|ms-|4.0.0 debugger-for-chrome|msj|4.3.0 php-docblocker|nei|1.6.0 vscode-icons|rob|7.23.0 stylelint|shi|0.36.0 wordpress-snippet|tun|1.1.2 sensitive-replace|vil|0.1.1 vscode-import-cost|wix|2.6.2 better-align|wwm|1.1.6 licenser|ymo|1.1.2 (1 theme extensions excluded)
swashata commented 6 years ago

This is also happening with the insider version.

2018-05-04_22-18-22

swashata commented 6 years ago

And here's the extensions host log

[2018-05-04 22:24:43.555] [exthost1] [info] extension host started
[2018-05-04 22:24:43.581] [exthost1] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:43.581] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/emmet/out/extension
[2018-05-04 22:24:43.654] [exthost1] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:43.654] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/git/out/main
[2018-05-04 22:24:43.860] [exthost1] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:43.860] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/merge-conflict/out/extension
[2018-05-04 22:24:43.877] [exthost1] [info] ExtensionService#_doActivateExtension EditorConfig.EditorConfig {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:43.877] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/EditorConfig.editorconfig-0.12.1/out/src/editorConfigMain
[2018-05-04 22:24:43.909] [exthost1] [info] ExtensionService#_doActivateExtension dbaeumer.vscode-eslint {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:43.909] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/dbaeumer.vscode-eslint-1.4.8/client/out/extension
[2018-05-04 22:24:43.971] [exthost1] [info] ExtensionService#_doActivateExtension esbenp.prettier-vscode {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:43.971] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/esbenp.prettier-vscode-1.3.1/out/src/extension
[2018-05-04 22:24:44.157] [exthost1] [info] ExtensionService#_doActivateExtension ionutvmi.path-autocomplete {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:44.157] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/ionutvmi.path-autocomplete-1.9.0/out/src/extension
[2018-05-04 22:24:44.175] [exthost1] [info] ExtensionService#_doActivateExtension joelday.docthis {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:44.175] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/joelday.docthis-0.6.0/out/src/extension
[2018-05-04 22:24:44.467] [exthost1] [info] ExtensionService#_doActivateExtension kamikillerto.vscode-colorize {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:44.467] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/kamikillerto.vscode-colorize-0.6.18/out/src/extension
[2018-05-04 22:24:44.484] [exthost1] [info] ExtensionService#_doActivateExtension ms-vscode.sublime-keybindings {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:44.484] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/ms-vscode.sublime-keybindings-4.0.0/out/extension
[2018-05-04 22:24:44.490] [exthost1] [info] ExtensionService#_doActivateExtension robertohuertasm.vscode-icons {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:44.490] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/robertohuertasm.vscode-icons-7.23.0/out/src/
[2018-05-04 22:24:44.548] [exthost1] [info] ExtensionService#_doActivateExtension tungvn.wordpress-snippet {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:44.548] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/tungvn.wordpress-snippet-1.1.2/extension
[2018-05-04 22:24:44.549] [exthost1] [info] ExtensionService#_doActivateExtension wix.vscode-import-cost {"startup":true,"activationEvent":"*"}
[2018-05-04 22:24:44.549] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/wix.vscode-import-cost-2.6.2/out/src/extension
[2018-05-04 22:24:45.059] [exthost1] [info] ExtensionService#_doActivateExtension vscode.npm {"startup":true,"activationEvent":"workspaceContains:package.json"}
[2018-05-04 22:24:45.059] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/npm/out/main
[2018-05-04 22:24:45.102] [exthost1] [info] ExtensionService#_doActivateExtension vscode.configuration-editing {"startup":false,"activationEvent":"onLanguage:jsonc"}
[2018-05-04 22:24:45.102] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/configuration-editing/out/extension
[2018-05-04 22:24:45.110] [exthost1] [info] ExtensionService#_doActivateExtension vscode.json-language-features {"startup":false,"activationEvent":"onLanguage:jsonc"}
[2018-05-04 22:24:45.110] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/client/out/jsonMain
[2018-05-04 22:24:45.370] [exthost1] [info] ExtensionService#_doActivateExtension bmewburn.vscode-intelephense-client {"startup":true,"activationEvent":"workspaceContains:**/*.php"}
[2018-05-04 22:24:45.370] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/bmewburn.vscode-intelephense-client-0.8.8/out/src/extension
[2018-05-04 22:24:45.445] [exthost1] [info] eager extensions activated
[2018-05-04 22:26:42.052] [exthost1] [info] extension host started
[2018-05-04 22:26:42.095] [exthost1] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.095] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/emmet/out/extension
[2018-05-04 22:26:42.188] [exthost1] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.188] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/git/out/main
[2018-05-04 22:26:42.447] [exthost1] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.447] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/merge-conflict/out/extension
[2018-05-04 22:26:42.459] [exthost1] [info] ExtensionService#_doActivateExtension EditorConfig.EditorConfig {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.459] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/EditorConfig.editorconfig-0.12.1/out/src/editorConfigMain
[2018-05-04 22:26:42.487] [exthost1] [info] ExtensionService#_doActivateExtension dbaeumer.vscode-eslint {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.487] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/dbaeumer.vscode-eslint-1.4.8/client/out/extension
[2018-05-04 22:26:42.544] [exthost1] [info] ExtensionService#_doActivateExtension esbenp.prettier-vscode {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.544] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/esbenp.prettier-vscode-1.3.1/out/src/extension
[2018-05-04 22:26:42.712] [exthost1] [info] ExtensionService#_doActivateExtension ionutvmi.path-autocomplete {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.712] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/ionutvmi.path-autocomplete-1.9.0/out/src/extension
[2018-05-04 22:26:42.733] [exthost1] [info] ExtensionService#_doActivateExtension joelday.docthis {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.733] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/joelday.docthis-0.6.0/out/src/extension
[2018-05-04 22:26:42.995] [exthost1] [info] ExtensionService#_doActivateExtension kamikillerto.vscode-colorize {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:42.995] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/kamikillerto.vscode-colorize-0.6.18/out/src/extension
[2018-05-04 22:26:43.012] [exthost1] [info] ExtensionService#_doActivateExtension ms-vscode.sublime-keybindings {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:43.012] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/ms-vscode.sublime-keybindings-4.0.0/out/extension
[2018-05-04 22:26:43.020] [exthost1] [info] ExtensionService#_doActivateExtension robertohuertasm.vscode-icons {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:43.020] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/robertohuertasm.vscode-icons-7.23.0/out/src/
[2018-05-04 22:26:43.085] [exthost1] [info] ExtensionService#_doActivateExtension tungvn.wordpress-snippet {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:43.085] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/tungvn.wordpress-snippet-1.1.2/extension
[2018-05-04 22:26:43.086] [exthost1] [info] ExtensionService#_doActivateExtension wix.vscode-import-cost {"startup":true,"activationEvent":"*"}
[2018-05-04 22:26:43.086] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/wix.vscode-import-cost-2.6.2/out/src/extension
[2018-05-04 22:26:43.693] [exthost1] [info] ExtensionService#_doActivateExtension vscode.npm {"startup":true,"activationEvent":"workspaceContains:package.json"}
[2018-05-04 22:26:43.693] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/npm/out/main
[2018-05-04 22:26:43.734] [exthost1] [info] ExtensionService#_doActivateExtension vscode.configuration-editing {"startup":false,"activationEvent":"onLanguage:jsonc"}
[2018-05-04 22:26:43.734] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/configuration-editing/out/extension
[2018-05-04 22:26:43.742] [exthost1] [info] ExtensionService#_doActivateExtension vscode.json-language-features {"startup":false,"activationEvent":"onLanguage:jsonc"}
[2018-05-04 22:26:43.742] [exthost1] [info] ExtensionService#loadCommonJSModule /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/json-language-features/client/out/jsonMain
[2018-05-04 22:26:43.998] [exthost1] [info] ExtensionService#_doActivateExtension bmewburn.vscode-intelephense-client {"startup":true,"activationEvent":"workspaceContains:**/*.php"}
[2018-05-04 22:26:43.998] [exthost1] [info] ExtensionService#loadCommonJSModule /Users/swashata/.vscode/extensions/bmewburn.vscode-intelephense-client-0.8.8/out/src/extension
[2018-05-04 22:26:44.093] [exthost1] [info] eager extensions activated
swashata commented 6 years ago

Got the issue. There was an invalid main in my package.json so it was silently failing.

It was only when I started the debugger (F5) it told me that either main and activationEvent both must be specified or omitted.

I think a better error popup, especially when reloading to activate the extension would help in future.

sandy081 commented 6 years ago

Thanks for filing the issue and figuring out the root cause.

These are errors which are thrown only during extension development and It is expected that the author runs the extension and make sure there are no errors before publishing.