microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.3k stars 28.9k forks source link

simplify telemetry implementation #5219

Closed jrieken closed 8 years ago

jrieken commented 8 years ago

Today we have an interface that describes the contract of telemetry (ITelemetryService) which is OK. The bad thing is that there many implementations of that interface (AbstractTS, MainTS, ElectronTS, AbstractRemoteTS, WorkerTS, ExtHostTS, NullTS, MockTS, TestTS) which have led to leakage and duplication of events. I believe this problem should be solved with less code and abstraction

jrieken commented 8 years ago

new structure is like this:

ITelemetryService implemented by:

jrieken commented 8 years ago

fyi @aeschli