Closed jrieken closed 8 years ago
new structure is like this:
ITelemetryService
implemented by:
NullTelemetryService
used in tests et alTelemetryService
implements a full telemetry serviceElectronTelemetryService
extends above and adds better machine/session identifiersRemoteTelemetryService
a proxy in workers/extension hostfyi @aeschli
Today we have an interface that describes the contract of telemetry (ITelemetryService) which is OK. The bad thing is that there many implementations of that interface (AbstractTS, MainTS, ElectronTS, AbstractRemoteTS, WorkerTS, ExtHostTS, NullTS, MockTS, TestTS) which have led to leakage and duplication of events. I believe this problem should be solved with less code and abstraction