search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.97k stars 29.19k forks source link

Won't Update #53873

Closed sosensible closed 6 years ago

sosensible commented 6 years ago

Issue Type: Bug

I tried to run the update four times this morning, and unless we have a five updates it seems something is amiss.

VS Code version: Code 1.24.1 (24f62626b222e9a8313213fb64b10d741a326288, 2018-06-13T17:51:32.889Z) OS version: Windows_NT x64 6.1.7601

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-4600M CPU @ 2.90GHz (4 x 2893)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_software
video_decode: enabled
video_encode: enabled
vpx_decode: unavailable_software
webgl: enabled
webgl2: enabled| |Memory (System)|15.91GB (4.78GB free)| |Process Argv|C:\Program Files\Microsoft VS Code\Code.exe| |Screen Reader|no| |VM|0%|
Extensions (33) Extension|Author (truncated)|Version ---|---|--- Bookmarks|ale|0.19.1 jenkins-status|ale|0.6.1 project-manager|ale|8.0.0 vscode-json|and|1.3.2 vscode-twig-pack|baj|1.0.0 gitignore|cod|0.5.0 git-extension-pack|don|0.1.3 githistory|don|0.4.1 gitlens|eam|8.4.1 restore-editors|eam|0.2.1 vscode-great-icons|emm|2.1.36 vscode-postman|eri|0.5.2 vscode-git-tags|how|1.3.1 rest-client|hum|0.19.0 jenkins-declarative-support|jmM|0.1.0 vscode-cflint|Kam|0.2.4 vscode-cfml|Kam|0.4.0 vscode-jira|Kni|0.6.0 dotenv|mik|1.0.1 mssql|ms-|1.4.0 python|ms-|2018.6.0 vsliveshare|ms-|0.3.379 vscode-coldbox|ort|0.1.0 vscode-testbox|ort|0.2.0 vscode-code-outline|pat|0.2.1 vscode-docker|Pet|0.0.27 git-merger|sha|0.4.1 slack|soz|0.0.14 cfml-comment-tags|trs|0.2.2 shell-launcher|Tyr|0.2.0 terminal-tabs|Tyr|0.2.0 vscode-todo-highlight|way|0.5.12 vscode-open-in-github|ziy|1.3.3
wunc commented 6 years ago

Similar issue. When I click on Code > Check for updates, I get no feedback. If I look again, that menu item turns into 'Downloading Update...' and then never changes. I can see in Activity Monitor that Code downloads ~71.3 Mb of data, but I never get a prompt to install the update.

VS Code v1.24.1 on macOS 10.13.5.

adrianthedev commented 6 years ago

I have the same issue. OSX 10.13.5, VSCode 1.23.1

wunc commented 6 years ago

I figured out and fixed my issue. In ~/Library/Application Support/Code/logs/[datetime]/main.log, I had the following error:

UpdateService error:  Could not locate update bundle for com.microsoft2.VSCode within ...

Notice the microsoft2. This was because I had previously done the hack of changing the bundle identifier to deal with issue #35361 . Even though I reverted the hack (changing com.microsoft2 back to com.microsoft in Info.plist), macOS for some reason still thought it was the former (you can check this by doing lsappinfo info -only bundleid Code while Code is running). I tried to figure out where that was cached so as to clear it, but couldn't. In the end, I just trashed the app, manually re-downloaded, and that fixed it.

I can't verify that it will actually update (because I'm now already on the latest version), but the error that was preventing updating is at least not showing up, and macOS is now reporting the correct bundle id.

adrianthedev commented 6 years ago

Mine was a different problem. I think I started code with sudo once and meesed up my permissions. The fix was sudo rm -Rf ~/Library/Caches/com.microsoft.VSCode.ShipIt from this post.

Your post @wunc helped me find out what the issue was. Thanks!

joaomoreno commented 6 years ago

OK, I'll focus on @sosensible's issue then.

@sosensible, you tried to run update and what happened? Did you get an error? Did the update complete? What is your latest version?

sosensible commented 6 years ago

I was running the current version, it said it updated and asked to restart. It restarted and then said there was another update... over and over.

joaomoreno commented 6 years ago

So... this is just the same as this old issue from you: https://github.com/Microsoft/vscode/issues/45413

Do you have any antivirus installed? Is your system managed by a system administrator? Can you reproduce on another machine?

sosensible commented 6 years ago

It is a work machine and yes there is antivirus installed. I have upgraded this product for about a year with the antivirus installed. We cannot turn it off per company standards. Other machines, that is a window 7 machine... works on windows 10 machine.

How can I verify exactly which version is actually installed?

joaomoreno commented 6 years ago

Since background updates are problematic for you, I suggest to disable them:

"update.enableWindowsBackgroundUpdates": false,

Does that fix it?

sosensible commented 6 years ago

That does appear to work.

From: João Moreno notifications@github.com Sent: Thursday, July 12, 2018 4:18 AM To: Microsoft/vscode vscode@noreply.github.com Cc: John Farrar johnfarrar@sosapps.com; Mention mention@noreply.github.com Subject: Re: [Microsoft/vscode] Won't Update (#53873)

Since background updates are problematic for you, I suggest to disable them:

"update.enableWindowsBackgroundUpdates": false,

Does that fix it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/53873#issuecomment-404429633 , or mute the thread https://github.com/notifications/unsubscribe-auth/AADmGdxwDEp7IAtLYcKWkxHpbmWLCLRDks5uFwZAgaJpZM4VHrj8 . https://github.com/notifications/beacon/AADmGVQRHI7v-wKDvyyrl9NsxolKrdL_ks5uFwZAgaJpZM4VHrj8.gif

joaomoreno commented 6 years ago

OK Let's leave it at that for now.