microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.73k stars 29.09k forks source link

Release notes opening as source code an not as HTML page as in previous version #54399

Closed jotamorais closed 6 years ago

jotamorais commented 6 years ago

Issue Type: Bug

Expected: After updating VS Code to latest version and restarting VS Code, one would expect the Release Notes to open as an HTML page (preview mode).

Actual: After updating and restarting VS Code, Release Notes opens as HTML source code.

VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z) OS version: Windows_NT x64 10.0.10586

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: unavailable_software
webgl: enabled
webgl2: enabled| |Memory (System)|15.68GB (5.38GB free)| |Process Argv|C:\Program Files\Microsoft VS Code\Code.exe| |Screen Reader|no| |VM|0%|
Extensions (41) Extension|Author (truncated)|Version ---|---|--- ng-template|Ang|0.1.9 vagrant|bbe|0.5.0 marko-beautify|bus|1.0.1 npm-intellisense|chr|1.3.0 path-intellisense|chr|1.4.2 angular2-snippets|dan|1.0.19 vscode-eslint|dba|1.4.12 vscode-npm-source|dku|1.0.0 xml|Dot|2.3.1 vscode-npm-script|eg2|0.3.5 prettier-vscode|esb|1.5.0 dotnet|for|0.0.4 ruby|gro|0.0.6 search-node-modules|jas|1.3.0 csharpextensions|jch|1.3.0 Angular2|joh|6.1.1 efcore-snippets|jul|0.0.5 dotnet-core-essentials|Kis|0.0.5 node-module-intellisense|lei|1.5.0 csharpfixformat|Leo|0.0.72 VS-code-vagrantfile|mar|0.0.7 dotnet-core-commands|mat|1.0.6 mssql|ms-|1.4.0 python|ms-|2018.6.0 csharp|ms-|1.15.2 PowerShell|ms-|1.8.1 vs-keybindings|ms-|0.2.0 debugger-for-chrome|msj|4.8.0 node-modules-resolve|nau|1.0.2 marko|pca|0.3.0 vscode-docker|Pet|0.0.27 tns-cli|pko|0.0.3 sonarlint-vscode|Son|1.4.0 vscode-helm|tec|0.3.0 nativescript|Tel|0.7.4 nativescript-xml-snippets|tsv|1.0.6 vscode-maven|vsc|0.9.2 nodejs-extension-pack|wad|0.1.9 nativescript-ng2-snippets|www|2.0.1 JavaScriptSnippets|xab|1.7.0 format-all-files|xyk|0.2.0
ard because it was too large to send. Please paste.
vscodebot[bot] commented 6 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

joaomoreno commented 6 years ago

What opens if you run F1, Show Release Notes?

jotamorais commented 6 years ago

@joaomoreno Pressing F1 actually showed an excerpt of our corporate proxy cover page. So, yeah, that helped to understand that our corp proxy is getting in our way.

This is similar to #53883

Appreciate your guidance here.

joaomoreno commented 6 years ago

Yeah this is definitely related to proxy issues.

The only way to fix this is to check for the content returned by the release notes Markdown URL, example: https://code.visualstudio.com/raw/v1_26.md

@gregvanl Is it safe to assume that the release notes always start with the following?

# MONTH YEAR (VERSION)
gregvanl commented 6 years ago

@joaomoreno Yes, there are no plans to change the h1 header.

eflamm commented 6 years ago

FWIW, I do not have a proxy connection, and while the release notes appear to be rendered as HTML, the links in the first section (Welcome to the June 2018 release...) are all prefixed with https://code.visualstudio.com/raw/... whereas if I open the release notes online, the links are https://code.visualstudio.com/updates/.... As a result, the links in the release notes don't open a browser window as expected.

image