file group index error

[ljporljp]

Issue Type: Bug

I have 2 group, file 1 is in group 1, file 2 is in group 2 , but Ctrl + 1 change to group 1,but focus on file 2, and Ctrl + 2 change to group 2 but foucs on file 1

VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z) OS version: Windows_NT x64 6.1.7601

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (4 x 3192)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: unavailable_software
webgl: enabled
webgl2: enabled| |Memory (System)|7.94GB (1.61GB free)| |Process Argv|D:\Pro\Microsoft VS Code\Code.exe| |Screen Reader|no| |VM|50%|

Extensions (46)

Extension|Author (truncated)|Version ---|---|--- better-comments|aar|1.2.6 lua-debug|act|0.3.6 Bookmarks|ale|9.0.1 code-gnu-global|aus|0.2.2 vscode-database|baj|1.5.2 path-intellisense|chr|1.4.2 vscode-svgviewer|css|1.4.4 vscode-markdownlint|Dav|0.18.0 vscode-eslint|dba|1.4.12 vscode-hasher|dee|1.0.1 jupyter|don|1.1.4 xml|Dot|2.3.1 gitlens|eam|8.5.2 tslint|eg2|1.0.34 file-icons|fil|1.0.12 code-runner|for|0.9.3 gc-excelviewer|Gra|2.1.24 beautify|Hoo|1.3.2 nsis|idl|3.13.2 latex-workshop|Jam|5.6.1 Lua|key|0.0.9 cmake-tools-helper|mad|0.2.1 vscode-clang|mit|0.2.2 ecdc|mit|0.12.0 vscode-language-pack-zh-hans|MS-|1.25.3 mssql|ms-|1.4.0 python|ms-|2018.7.1 vscode-ai|ms-|0.1.9 cpptools|ms-|0.17.7 csharp|ms-|1.15.2 Go|ms-|0.6.84 PowerShell|ms-|1.8.1 debugger-for-chrome|msj|4.8.0 color-highlight|nau|2.3.0 qub-xml-vscode|qub|1.2.8 java|red|0.28.0 vscode-icons|rob|7.24.0 code-settings-sync|Sha|3.0.0 shader|sle|1.1.3 vscode-lua|tri|0.12.4 cmake|twx|0.0.17 unity-debug|Uni|1.3.0 cmake-tools|vec|1.1.0 vscode-redis|vit|1.2.0 vscode-java-debug|vsc|0.10.0 markdown-all-in-one|yzh|1.6.0 (1 theme extensions excluded)

[vscodebot[bot]]

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Save All in Group saves files across groups instead of just the group in the current context (#50737)
• Open Editors section should scroll to show group name (#50740)
• Create a new group when moving an editor to the next group (#52615)
• Allow to open an editor into a specific editor group (#49026)
• 'Move editor in right group' command is confusing (#50664)

[kieferrm]

@ljporljp I can't reproduce on 1.25.1 on Win10. Works for me as expected.

[kieferrm]

/needsMoreInfo

[vscodebot[bot]]

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

[ljporljp]

I have found this bug how to reproduce! Follow me: 1、Open one workspace (can empty dir). 2、Create 3 or more files. 3、Move any of these files separately to 3 or more groups.

[ljporljp]

These groups should be drag to created

[kieferrm]

@ljporljp thanks!

When you create a 2x2 grid and fill it from the top left, top right, bottom left, to the bottom right you get different results on macOS and Windows.

On mac: | Cmd+1 | Cmd+2 | | Cmd+3 | Cmd+4 |

On windows: | Ctrl+1 | Ctrl+3 | | Ctrl+2 | Ctrl+4 |

I'd expect VS Code on Windows to behave the same as on the mac.

[bpasero]

@kieferrm I do not think what you describe is related to the issue, what you see very much depends on the initial orientation of the grid. Cmd+1, Cmd+2, etc. works in grid order, not in visual order, so if the root orientation is vertical vs horizontal, it can well be that Cmd+2 brings you to the bottom left corner. @joaomoreno and me figured out this might be unexpected, but we did not want to push this further and wait for users to complain.

@ljporljp I am trying to understand your issue or reproduce, are you saying that you have 2 files open side by side and Ctrl+1 correctly activates the left editor, but the blinking cursor stays in the right editor? Can you attach a video?

[ljporljp]

@bpasero No, sorry for my poor present leading you misunderstand and can not reproduce. Clearly: this can reproduce without the workbench-grid layout. i just drag to add the third horizontal group, then ctrl+N(1,2,3) just mismatch the opened eidtor's(in the left panel) index.

[bpasero]

@ljporljp Ctrl+Number is for switching editor groups, not editors. You can change keybindings to alter that behaviour. I am going to close this issue now that I understand your issue.

[ljporljp]

@bpasero no, you don't understand me. And I know Ctrl + N is for switching editor groups , I do mean that Ctrl + N mismatch the showing group index in the open editors index by my way. Above is Ctrl + 2, but focus on group 3.

[bpasero]

@ljporljp I see no bug in the screenshot you posted, it looks like "test3.lua" has focus which is in the second group and you pressed Ctrl+2?

[ljporljp]

@bpasero test3.lua is in third group ! You should see it at the left opened editors .it's in "第 3 组", and i really pressed Ctrl + 2 !

[bpasero]

@ljporljp interesting, yeah it looks like the "open editors" view is out of sync with what is showing on the right hand side.

Can you give me any more detailed steps how to reproduce this issue, ideally from scratch from an empty state where no editor is opened? Thanks!

[ljporljp]

@bpasero Ok, I have to post some screenshots to you.

[bpasero]

@ljporljp thanks for the explanation! this actually works as designed now that I see how you got there. The order in the "open editors" view is by creation time of the group, not in visual order. Otherwise the open editors view would update quite frequently when you change layouts. We decided to go with this to reduce noise in the view.

//cc @isidorn

[ljporljp]

@bpasero But this made inconsistent and confused. So i think it's just not implemented well.

[bpasero]

Let's treat this as a candidate for a setting, I have opened https://github.com/Microsoft/vscode/issues/56084

I am willing to revisit the decision as originally I was also confused by what I saw.