Prompt to disable extension vs. pack

[chrmarti]

Issue Type: Bug

Testing #54862

This is hard to understand without the underlying technical background:

Why not always disable the entry pack and not offer the other option? Packs will usually not contain any functionality themselves, so it won't make sense to only disable the extension.

VS Code version: Code - Insiders 1.26.0-insider (5fae91d61f12726e149fe5baed342eac2fbf8f88, 2018-07-25T01:56:56.548Z) OS version: Darwin x64 17.7.0

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|4, 4, 4| |Memory (System)|16.00GB (0.58GB free)| |Process Argv|/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron| |Screen Reader|no| |VM|22%|

Extensions (21)

Extension|Author (truncated)|Version ---|---|--- 999-pack1|chr|0.12.0 regex|chr|0.2.0 ssh|chr|0.0.4 vscode-eslint|dba|1.4.12 Spot|der|0.4.0 ghlink|dt|1.0.2 EditorConfig|Edi|0.12.4 tslint|eg2|1.0.34 rest-client|hum|0.19.0 vscode-azureappservice|ms-|0.9.0 vscode-azurefunctions|ms-|0.10.0 vscode-cosmosdb|ms-|0.8.0 azure-account|ms-|0.4.2 azurecli|ms-|0.4.2 github-issues-prs|ms-|0.9.0 PowerShell|ms-|1.8.1 debugger-for-chrome|msj|4.8.2 vscode-docker|Pet|0.0.27 vscode-versionlens|pfl|0.21.1 vscode-open-in-github|sys|1.7.0 azure-iot-toolkit|vsc|1.1.0

[chrmarti]

Similarly: Don't ask if the pack should be uninstalled, always uninstall the extension only:

That will make the interaction simpler. A user intending to uninstall the pack...needs to uninstall the pack.

[sandy081]

Makes sense

[weinand]

@chrmarti you said:

Packs will usually not contain any functionality themselves, so it won't make sense to only disable the extension.

That this is not the case I learned from the Java Debugger, which is a pack and a debugger: if you disable the debugger (and you are not aware that this is a pack) it is good to have the choice of keeping the Java extension still enabled.

With your suggestion there would be no way to only disable the debugger.

see related issue #55057

[chrmarti]

@weinand Removing the prompts as proposed by #55055 will simplify the UX. With that to allow for uninstalling the Java Debugger without uninstalling the Java extension, there will be two options:

• The Java Debugger declares the Java extension as a dependency (not part of a 'pack'). (Preferred if the Java Debugger requires the Java extension to be present.)
• We introduce a Java Extension Pack with the Java extension and the Java Debugger as part of the pack. (Preferred if the two extensions do not require the other extension being installed.)

[sandy081]

Java debugger has functional dependency on Java extension. So disabling Java debugger should be either disable only that extension (when not prompted) or show a prompt to disable extension only or its dependencies also (current behaviour).

As explained in #55055, disabling / uninstalling extensions with dependencies will show a prompt to choose only or with dependencies so that we an give some time for real extension packs to adopt to new property.

Where as Disabling / uninstalling extension packs (using new property) will be done as a pack without prompts.

Hence marking this as a dup of #550555