microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.33k stars 28.59k forks source link

Seti file icon theme: support more "todo" files #56143

Closed fabiospampinato closed 6 years ago

fabiospampinato commented 6 years ago

Should I have opened this issue on https://github.com/jesseweed/seti-ui instead?

There's already a custom file icon for files named TODO, I think the same icon should be used for these other files, which are supported by Todo+ and other extensions, as well:

vscodebot[bot] commented 6 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

aeschli commented 6 years ago

Yes, this needs to be filed against https://github.com/jesseweed/seti-ui (we generate the vscode seti theme from there)

aeschli commented 6 years ago

Oh, I see you define a todo language. I can assign the seti todo icon to the todo language.

fabiospampinato commented 6 years ago

That would be great, thank you.

jrieken commented 6 years ago

Using Seti and the Todo+ extension I still get the default icon

screen shot 2018-08-28 at 16 47 03
fabiospampinato commented 6 years ago

It's working for me on v1.27.0 👍

screen shot 2018-09-06 at 22 09 38
aeschli commented 6 years ago

Thanks, marking as verified.