Closed zvinless closed 6 years ago
I can reproduce and verified that the icon classes seem to be correct:
This only seems to reproduce if the file ends with .txt
@bpasero I didn't test the extensions exhaustively, but here's a few cases:
By design, an icon association for a file extension is stronger than for a language association. (see https://code.visualstudio.com/docs/extensions/themes-snippets-colorizers#_adding-a-new-icon-theme)
In the case of txt it doesn't make much sense to have a file association as is the default as well.. Removing the file association will fix it for txt. For all other this is as designed.
Steps to Reproduce:
I expected that the Lua icon would be used for both files.
Does this issue occur when all extensions are disabled?: Yes
Extra info: I've tried this with a variety of file extensions. From what I've found, I can't override anything defined in the seti theme's
fileExtensions
orfileNames
, i.e.: https://github.com/Microsoft/vscode/blob/ba98d69588cd88e3f47ea23dfb31d9145cab3cbe/extensions/theme-seti/icons/vs-seti-icon-theme.json#L1246-L1427 https://github.com/Microsoft/vscode/blob/ba98d69588cd88e3f47ea23dfb31d9145cab3cbe/extensions/theme-seti/icons/vs-seti-icon-theme.json#L1778-L1823 but that I can override entries found in thelanguageIds
table. I feel like file associations should take precedence over extensions or filenames. Might be somewhat related to #12493.