microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.43k stars 29.34k forks source link

Disabling Emmet doesnt stop some of the Emmet commands from showing up #58600

Closed WORMSS closed 1 year ago

WORMSS commented 6 years ago

I would like to disable Emmet.. And I mean, Disable ALL of it..
As if it's not in VS code at all..

It just pollutes the commands list.

image

If Emmet was an extension, I could just uninstall it.. but it seems to be built in and not able to remove it.

vscodebot[bot] commented 6 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

lannonbr commented 6 years ago

@WORMSS, If you open the extensions tab and type @builtin to the search box, Emmet is a built in extension that will appear and you can disable it in a specific workspace or entirely:

screen shot 2018-09-13 at 8 42 01 am

WORMSS commented 6 years ago

Ahh, thank you @lannonbr I had no idea you could list the built in..

The irony, now that I know extensions can show extra stuff. I have noticed the ... dots to list everything.. I am sorry I feel so dumb..

image

WORMSS commented 6 years ago

@lannonbr it seems it doesn't disable it enough..
2 commands are still added.. And if you try to call them, they throw an error..

image

image

image

ramya-rao-a commented 5 years ago

@octref The 2 commands in https://github.com/Microsoft/vscode/issues/58600#issuecomment-421003237 are contributed by the core and not the built-in extensions.

Since extensions have no way of knowing the language under the cursor, we use the core command Emmet: Expand Abbreviation to figure out the language and then call the corresponding command from the built-in extension. This was done to avoid regression when we moved the Emmet features out to an extension.

The way to fix this bug is for the core to somehow figure out that the built-in extension is disabled, and then disable the above 2 commands

ghost commented 4 years ago

Why is Emmet even built-in anyway? I doubt even 10% of VS Code users use it.

rzhao271 commented 3 years ago

Verifier:

  1. Disable the Emmet extension
  2. Open the command palette and search for Emmet commands

Ensure no Emmet commands show in the results

WORMSS commented 3 years ago

image

image

@rzhao271

rzhao271 commented 3 years ago

Lol @WORMSS you're too fast. The issue is currently labelled as "unreleased". Please wait for the next Insiders release tomorrow, after the bot labels the issue as "insiders-released".

rzhao271 commented 3 years ago

Is the issue resolved for you now? You'll need to download the Insiders version to verify the fix: https://code.visualstudio.com/insiders/

rzhao271 commented 3 years ago

Seems like moving the Expand Abbreviation command from workbench to Emmet broke keybinding precedence, so I'll have to revert this change for now.

cesarvarela commented 3 years ago

I think vscode has reached a point were removing features is better than adding them. Emmet being one of them 😄

rzhao271 commented 1 year ago

Closing in favour of #110899