search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.45k stars 28.62k forks source link

Application contextual menu is no more displayed after a SHIFT+ right click in Windows Taskbar #60769

Closed ypapouin closed 1 year ago

ypapouin commented 5 years ago

Issue Type: Bug

After setting new menu style

"window.titleBarStyle": "custom"

Application contextual menu is no more displayed after a SHIFT+ right click in Windows Taskbar. If you revert to native, the menu comes back.

sshot-92

Note that in both configuration, a right click on the title bar is correctly showing the application contextual menu.

sshot-94

VS Code version: Code 1.28.1 (3368db6750222d319c851f6d90eb619d886e08f5, 2018-10-11T18:13:53.910Z) OS version: Windows_NT x64 10.0.17134

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 4200)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled| |Memory (System)|15.96GB (8.39GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (44) Extension|Author (truncated)|Version ---|---|--- Bookmarks|ale|9.1.0 copy-word|ale|2.1.0 pascal|ale|6.4.0 multiline-find-and-replace|axl|0.0.1 django-html|bib|1.2.0 path-intellisense|chr|1.4.2 bracket-pair-colorizer|Coe|1.0.60 smoothscroll|cya|1.0.4 createuniqueid|don|0.0.3 jquerysnippets|don|0.0.1 xml|Dot|2.3.2 gitlens|eam|8.5.6 vscode-npm-script|eg2|0.3.5 vsc-material-theme|Equ|2.4.2 battery-indicator|fbo|1.0.0 shortcuts|giz|0.0.1 output-colorizer|IBM|0.1.2 path-autocomplete|ion|1.12.0 switchit|jbe|1.0.2 csharpextensions|jch|1.3.0 vscode-random|jre|1.3.2 vscode-insertdatestring|jsy|2.2.3 vscode-icon-theme|jtl|1.6.5 docomment|k--|0.1.2 python|ms-|2018.9.0 cpptools|ms-|0.19.0 csharp|ms-|1.16.2 mono-debug|ms-|0.15.8 PowerShell|ms-|1.9.0 trailing-semicolon|nau|1.0.2 indent-rainbow|ode|7.2.4 vscode-docker|Pet|0.3.1 diff|raf|0.0.1 classynaming|ref|1.2.0 code-settings-sync|Sha|3.1.2 shader|sle|1.1.4 vscode-hexdump|sle|1.7.0 vscode-multiclip|sle|0.1.5 unity-debug|Uni|1.3.0 transpose|v4r|0.0.5 vscode-todo-highlight|way|1.0.4 vscode-surround|yat|1.0.2 unity-snippets|Ycl|0.1.2 html-css-class-completion|Zig|1.17.1 (3 theme extensions excluded)
sbatten commented 5 years ago

see https://github.com/electron/electron/issues/12134

myfairsyer commented 5 years ago

As I already wrote in #65900: The Window Menu doesn't open either when left clicking the custom titlebar's icon on Windows, nor does of course double-clicking the icon execute the menu's default item and close the window.

Edit: I just saw that #58199 is about just that issue and #65092 about adding the setting @sbatten mentions here that at least allows to close the window by double clicking the icon.

myfairsyer commented 5 years ago

Why/how is it being displayed when right clicking the titlebar?

sbatten commented 5 years ago

@myfairsyer That menu is provided by Windows itself and with frameless menus, it only comes up on right-click of draggable regions like the titlebar. The app icon can have double click to close but this removes the ability to drag the window from the top left. The setting is window.doubleClickIconToClose

sbatten commented 4 years ago

Another electron issue with frameless windows. Feel free to close out of scope.

deepak1556 commented 1 year ago

Closing as upstream issue has been closed.