Accepting suggestions with semicolon is way too eager

[Zarel]

Issue Type: Bug

I just typed:

this.started = true

and pressed semicolon, and this autocompleted to:

this.started = turnTicksLeft;

This is clearly massively undesirable.

The behavior is somewhat inconsistent; here it is happening:

And here it is, working just fine:

After screwing around, I couldn't get it to happen again. But I've definitely been pretty frustrated by semicolon completions so far.

VS Code version: Code 1.28.1 (3368db6750222d319c851f6d90eb619d886e08f5, 2018-10-11T18:07:48.477Z) OS version: Darwin x64 18.0.0

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Xeon(R) CPU E5-1620 v2 @ 3.70GHz (8 x 3700)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 2| |Memory (System)|16.00GB (0.03GB free)| |Process Argv|-psn_0_57358| |Screen Reader|no| |VM|0%|

Extensions (2)

Extension|Author (truncated)|Version ---|---|--- vscode-pull-request-github|Git|0.2.1 sublime-commands|Zar|0.1.0

[vscodebot[bot]]

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Editor enhancement request: impelementation of a trailing semicolon toggle (#24862)

[Zarel]

https://github.com/Zarel/Pokemon-Showdown/blob/master/room-battle.js

is the file I was working on, in case it's useful.

[Zarel]

I just typed this.checkActive( and it autocompleted to this.this.checkActive()

Clearly there's something wrong with autocompletions.

[mjbvz]

You can disable semi-colon accept by setting: "editor.acceptSuggestionOnCommitCharacter": false

The part with true not showing up and this.this.checkActive sounds like #59848. If you have reliable repo steps please let me know

[vscodebot[bot]]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!