microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.2k stars 29.29k forks source link

Error when installing 1.28 deb #61811

Closed Tyriar closed 6 years ago

Tyriar commented 6 years ago

/usr/share/applications/code-url-handler.desktop: warning: key "MimeType" is a list and does not have a semicolon as trailing character:

screen shot 2018-10-25 at 9 29 01 am
joaomoreno commented 6 years ago

@joaomoreno Check https://github.com/Microsoft/vscode/pull/56727

joaomoreno commented 6 years ago

This is pretty weird. I can't reproduce:

joao@joao-ubuntu-vm:~$ sudo apt install code
[sudo] password for joao: 
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following NEW packages will be installed:
  code
0 upgraded, 1 newly installed, 0 to remove and 171 not upgraded.
Need to get 44.0 MB of archives.
After this operation, 196 MB of additional disk space will be used.
Get:1 http://packages.microsoft.com/repos/vscode stable/main amd64 code amd64 1.28.2-1539735992 [44.0 MB]
Fetched 44.0 MB in 1s (39.8 MB/s)
Selecting previously unselected package code.
(Reading database ... 170774 files and directories currently installed.)
Preparing to unpack .../code_1.28.2-1539735992_amd64.deb ...
Unpacking code (1.28.2-1539735992) ...
Processing triggers for mime-support (3.60ubuntu1) ...
Processing triggers for desktop-file-utils (0.23-1ubuntu3.18.04.1) ...
Setting up code (1.28.2-1539735992) ...
Processing triggers for gnome-menus (3.13.3-11ubuntu1.1) ...

But I also didn't fix anything.

The code looks good, as there is a semicolon in there: https://github.com/Microsoft/vscode/blob/03f7c83b237ceb2ea8fd5eac90c21bd3b2512ceb/resources/linux/code-url-handler.desktop#L12

When I download that exact same deb, and extract it, I verify that the semicolon is there. :thinking:

Let me know if you still hit it, reopen if you can reproduce.

nsolthe commented 6 years ago

Hi @joaomoreno, I had this issue too an I am still having it. I removed an reinstalled it. At the end I listed the content of my .desktop file

nsol@MintMashine ~ $ sudo apt-get remove code
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following packages will be REMOVED:
  code
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
After this operation, 196 MB disk space will be freed.
Do you want to continue? [Y/n] Y
(Reading database ... 284421 files and directories currently installed.)
Removing code (1.28.2-1539735992) ...
Processing triggers for gnome-menus (3.13.3-6ubuntu3.1) ...
Processing triggers for desktop-file-utils (0.22+linuxmint1) ...
Processing triggers for mime-support (3.59ubuntu1) ...
nsol@MintMashine ~ $ sudo apt-get install code
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following NEW packages will be installed:
  code
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/44,0 MB of archives.
After this operation, 196 MB of additional disk space will be used.
Selecting previously unselected package code.
(Reading database ... 282479 files and directories currently installed.)
Preparing to unpack .../code_1.28.2-1539735992_amd64.deb ...
Unpacking code (1.28.2-1539735992) ...
Processing triggers for gnome-menus (3.13.3-6ubuntu3.1) ...
Processing triggers for desktop-file-utils (0.22+linuxmint1) ...
Processing triggers for mime-support (3.59ubuntu1) ...
Setting up code (1.28.2-1539735992) ...
/usr/share/applications/code-url-handler.desktop: warning: key "MimeType" is a list and does not have a semicolon as trailing character, fixing
nsol@MintMashine ~ $ cat /usr/share/applications/code-url-handler.desktop
[Desktop Entry]
Name=Visual Studio Code - URL Handler
Comment=Code Editing. Redefined.
GenericName=Text Editor
Exec=/usr/share/code/code --open-url %U
Icon=code
Type=Application
NoDisplay=true
StartupNotify=true
StartupWMClass=Code
Categories=Utility;TextEditor;Development;IDE;
MimeType=x-scheme-handler/vscode;
Keywords=vscode;
X-Desktop-File-Install-Version=0.22

Regrads, nsol

joaomoreno commented 6 years ago

Since this is just a warning, I'll leave it closed. I still can't repro and I'm pretty sure the semicolon is in there inside the package... so... maybe @Tyriar has an idea?

Tyriar commented 5 years ago

It certainly has a semicolon at the end?

https://github.com/Microsoft/vscode/blob/beb5998ea3d6b4cae43b3a09ecdf11e3bd692667/resources/linux/code-url-handler.desktop#L11