search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
165.05k stars 29.56k forks source link

Open Editors shows vertical scrollbar when horizontal scrolling enabled #67441

Closed chrmarti closed 5 years ago

chrmarti commented 5 years ago

Issue Type: Bug

Testing #67275

It appears to grow/shrink with the number of entries, but forgets to disable the vertical scrollbar:

image

VS Code version: Code - Insiders 1.31.0-insider (acc7365e41f9cb380e79bf78d7d102184f1ffe0d, 2019-01-29T06:14:22.700Z) OS version: Linux x64 4.15.0-39-generic

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (2 x 2194)| |GPU Status|2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: disabled_off
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
surface_synchronization: enabled_on
video_decode: unavailable_off
webgl: enabled
webgl2: enabled| |Load (avg)|0, 0, 0| |Memory (System)|5.77GB (0.47GB free)| |Process Argv|--unity-launch| |Screen Reader|no| |VM|100%|
Extensions (7) Extension|Author (truncated)|Version ---|---|--- tslint|eg2|1.0.42 beautify|Hoo|1.4.7 theme-karyfoundation-themes|kar|18.2.1 azure-account|ms-|0.8.0 lsp-inspector|oct|0.0.1 vscode-open-in-github|sys|1.10.1 ayu|tea|0.17.0
joaomoreno commented 5 years ago

This is because we need to reserve x pixels of space in the bottom, so the horizontal scrollbar doesn't overlap the last element. Moving to you @isidorn for when you come back 👍

themowski commented 5 years ago

Bumping this old issue because I'm seeing the effects in stable v1.33.1 on Win 10, and it's really noticeable / bad when only one editor/file is open:

editor

As you can see, the total vertical space is big enough for exactly 1 file, which is correct, but the reserved space for the horizontal scrollbar takes up about half of that space, and the file's entry ends up getting pushed up and effectively cut in half. This makes the file name difficult to read.

You can scroll the "Open Editors" tab up to "fix" this temporarily, but if you close the editors and open a new one, this is the default view.

UPDATE: I just realized, this behavior is inconsistent. To the best that I can tell, it seems that if you open/preview a text file (something you can edit), this happens, but if you preview/try to open a binary file, it doesn't happen.

VS Code version: 1.33.1 (user setup) OS: Windows 10

vscodebot[bot] commented 5 years ago

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

olegbl commented 4 years ago

This is because we need to reserve x pixels of space in the bottom, so the horizontal scrollbar doesn't overlap the last element

The scroll bar still overlaps content (as visible in the screenshot in this bug report). So, it's introducing a new bug without solving the bug it's meant to solve :P

To solve both issues, what needs to grow by the height of the scroll bar is the container not the content.

nitin2953 commented 3 years ago

FIX: Set "workbench.list.horizontalScrolling": false