Allow a touchbar that overflows

[shpontex]

• VSCode Version: 1.31.0
• OS Version: mac os mojave 10.14.2 i tried almost all the touch bar extensions but no one seems to work anymore

[vscodebot[bot]]

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Notification bars don't response touching (#66309)
• Touch support can be improved in webviews (#21812)

[bpasero]

Likely caused by: https://github.com/electron/electron/issues/16473

[bpasero]

@shpontex I cannot reproduce what you describe with the following steps. Unfortunately I do not own a MacBookPro with native touchbar, so I have installed the touchbar simulator (https://sindresorhus.com/touch-bar-simulator/)

• start Code
• install Nasc VSCode Touchbar
• find new buttons in the touchbar

The change with Electron 3 that we had to work on was a change in how large icons would appear in the touchbar. They showed up much larger causing the touchbar to drop all the debug items at the end because space got little. It is possible that extensions have to update their icon sizes to account for that, however Nasc VSCode Touchbar seems to work just fine for me.

[bpasero]

One thing that might help is to disable "Show control strip" from:

[bpasero]

@isidorn @misolori you seem to have added a new entry to the debug touchbar (Start without Debug) which could also have an impact. By that you reduced the size of the touchbar by one item, and as such if an extension adds a lot of other items there is a chance that those items get removed.

I am hijacking this issue to have the real proper fix which is to implement a touchbar that simply scrolls left and right.

If someone wants to look into this, be my guest. Touchbar is created in https://github.com/Microsoft/vscode/blob/58fb98d/src/vs/code/electron-main/window.ts#L988

[shpontex]

@bpasero thank you for your explanation i confirm Nasc VSCode Touchbar work if i hide the control strip other plugins too i tried before to remove two buttons on the Touch Bar Display Commands extension "which contains only 5 buttons" but it didnt work

[justinchan23]

@bpasero thank you for your explanation i confirm Nasc VSCode Touchbar work if i hide the control strip other plugins too i tried before to remove two buttons on the Touch Bar Display Commands extension "which contains only 5 buttons" but it didnt work

i submitted a pr to update the nasc vscode touchbar to work with vscode v1.31.0 with or without the control strip.

[alistairholt]

@isidorn @misolori you seem to have added a new entry to the debug touchbar (Start without Debug) which could also have an impact. By that you reduced the size of the touchbar by one item, and as such if an extension adds a lot of other items there is a chance that those items get removed.

I am hijacking this issue to have the real proper fix which is to implement a touchbar that simply scrolls left and right.

If someone wants to look into this, be my guest. Touchbar is created in https://github.com/Microsoft/vscode/blob/58fb98d/src/vs/code/electron-main/window.ts#L988

This is how it should function IMO. Being restricted to a fixe-width space is not a great long-term solution.

[pelmers]

I'd like to give this issue a shot by using the TouchBarScrubber (https://electronjs.org/docs/api/touch-bar-scrubber).

[pelmers]

I wasn't able to solve this with current Electron APIs, I filed an issue upstream at https://github.com/electron/electron/issues/16936.

[albelin]

Hi, I am a new user here looking to contribute to the repo. Is this task still available?

[hasimyerlikaya]

Hello to everyone. I was looking for a solution because I couldn't use the Touch Bar when debugging. I am developing a mobile application with Flutter and found a solution in my own way. I wanted to share with you the idea that it can be useful as well. I solved the problem by customizing the Touch Bar. I just added the tools I use most to the "Control Strip" field. In this way, the area there was reduced and the debug buttons were opened. I lost two of the Debug buttons, but I didn't use it much. Now I am very happy with this use. You can use it that way too.

[vscodebot[bot]]

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!