vscodebot[bot]
commented
5 years ago (Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
Closed thany closed 4 years ago
vscodebot[bot]
commented
5 years ago (Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:
roblourens
commented
5 years ago I don't think that's the default keybinding, we don't set ctrl+alt keybindings by default on windows for just this reason. You can see https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-generic-keybindings for more info
thany
commented
5 years ago I see. I must've changed it at some point. Okay, so can it be fixed? Ctrl+Alt shortcuts should overrule inserting Ctrl+Alt+? characters, as they do in every other program, including Microsoft's other coding tool: Visual Studio ;)
SylwesterZarebski
commented
5 years ago Please look at https://github.com/Microsoft/vscode/issues/50341, which could fix this problem (PS. when applied of course).
alexdima
commented
5 years ago @thany what keyboard layout do you have configured in Windows ?
thany
commented
5 years ago @alexandrudima US-international
alexdima
commented
5 years ago @thany I cannot reproduce. I have configured the following in keybindings.json:
// Place your key bindings in this file to override the defaults
[
{
"key": "ctrl+alt+s",
"command": "workbench.action.files.saveAll"
}
]I have changed my keyboard layout to English INTL:
thany
commented
5 years ago I'm sure the onscreen keyboard works differently. The layout youre using there, that's not actually Qwerty US. Not even close. Regardless, does it help to know I'm using a XPS15? I don't have an AltGR, but I do have two Alt and two Ctrl keys. I'm always using the left ones.
Are you sure ENG/INTL was selected there?.. It look like ENG/US was selected. On my system, a selection is darker.
Another difference is that I'm on English UK, whereas you're on US. Not sure if that makes all the difference. You never know.
alexdima
commented
5 years ago @thany
Can you please open an editor and execute the command Developer: Inspect Key Mappings and paste here the output?
thany
commented
5 years ago Sure, here you go:
alexdima
commented
5 years ago @thany I have configured the same keyboard layout and Ctrl+Alt+S works for me.
{
"name": "00020409",
"id": "0001",
"text": "United States-International"
}I wonder if VS Code receives the keybinding from the OS?
thany
commented
5 years ago If I do the same, I first see "ctrl + alt" appearing while pressing those keys. As soon as I press the S in addition, it turns into "s". No matter how firmly I keep holding the Ctrl and Alt keys. Onscreen keyboard does the same.
Strangely, at my fullsize computer back home I've got the same keyboard&language®ion settings, but I'm getting what you're getting. I don't understand why it's like this on my laptop.
But at the same time, the Ctrl+Alt+S shortcut works perfectly fine in Notepad++. It does a Save As command there, and doesn't insert any ß characters. Onscreen keyboard does the same.
alexdima
commented
5 years ago @thany Can you please open https://www.w3.org/2002/09/tests/keys.html in Chrome. Can you record a clean ctrl+alt+s press in there and share the log? How does the log look on the same machine in Edge?
Here is how a log where things work looks like:
----> keydown: [keyCode: 83][shift: false][ctrl: true][alt: true][meta: false]We need to see if an entry appears with keydown, keyCode: 83, ctrl: true and alt: true.
thany
commented
5 years ago alexdima
commented
5 years ago Thank you for recording this. This looks like an upstream issue with Chromium. May I kindly ask that you open an issue directly with Chromium at https://bugs.chromium.org/p/chromium/issues/list . The developers on that project can then reach out to you directly with further questions if they would have any...
You can explan how Ctrl+Alt+S is not generating the correct DOM events and show exactly these recordings that you have done at https://www.w3.org/2002/09/tests/keys.html
The difference is obvious around these events:
Chrome:
keydown (4): [keyCode: 83][shift: false][ctrl: false][alt: false][meta: false]
keydown (5): [keyCode: 83][shift: false][ctrl: false][alt: false][meta: false]
Edge:
keydown (4): [keyCode: 83][shift: false][ctrl: true][alt: true][meta: false]
keydown (5): [keyCode: 83][shift: false][ctrl: true][alt: true][meta: false]Note how Chrome gives ctrl: false and alt: false when Edge gives ctrl+ true and alt: true.
l0k18
commented
5 years ago The binding doesn't exist by default in linux (?) but I was wanting a shortcut so I tried it and lo and behold, it works! It's very useful when one cuts a piece from one open file and pastes it into another (which I wish was dnd). For this reason I also want it to have a default but since I can set it this way, maybe somehow in resolution of this issue for windows users, this command could have a default key combination?
Not very helpful comment, I know, but I'm pretty sure you will find the issue is upstream as the above remark notes.
thany
commented
5 years ago Sad to find out this issue did not get fixed in the latest update, 1.35.
Can someone from the VScode team please take it up with the Chromium team? I don't want to become a messenger between two teams that oughta work together.
I'm sure Microsoft is already working closely with Chromium anyway.
alexdima
commented
5 years ago Can someone from the VScode team please take it up with the Chromium team? I don't want to become a messenger between two teams that oughta work together.
@thany This is an issue specific to your machine, hardware and software. I cannot reproduce. You should therefore talk directly to Chromium developers, who can ask you the right questions in trying to fix your problem. What kind of issue can I file against Chromium if I cannot reproduce myself?
thany
commented
5 years ago Similarly, I don't know what exactly to tell them 😄
(assumption mode) As far as the Chromium browser is concerned, Ctrl+Alt+A completely correctly produces an à, like it does in every text input in every other program. It seems to me that VScode is somehow registering hotkeys (which I don't think is default browser stuff) where something is not correctly overriding the keyboard events or something.
alexdima
commented
5 years ago How can we come full circle to guessing... :)
...
We have identified the problem. On your machine, when pressing Ctrl+Alt+S, the Edge browser generates a keydown event with the modifiers ctrl and alt and keyCode: 83, while Chrome does not. You have collected traces which show this. That is what you need to tell to the Chrome team...
I am sorry but there is no possible code change I can do in VS Code if VS Code does not receive a keydown event...
alexdima
commented
4 years ago Related - #81268
vscodebot[bot]
commented
4 years ago This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding and happy coding!
Issue Type: Bug
When I press Ctrl+Alt+S, instead of performing the Save All command, it inserts a
ßinto the document. Typically Ctrl+Alt hotkeys override WIndows' behaviour to insert characters like that.I personally don't use the ß character, but anyone who does, would probably need to remap the Save All command. It's a tossup. But in the end, the File menu promises to Save All when pressing Ctrl+Alt+S, which isn't happening.
RightAlt+S also inserts a ß character, btw, but I'm not aware that my keyboard has an AltGr. My keyboard layout is set to US-international, my locale is English UK. My physical keyboard is the US layout of a Dell XPS 9570.
This bug also occurs with all extensions disabled.
VS Code version: Code 1.32.1 (05f146c7a8f7f78e80261aa3b2a2e642586f9eb3, 2019-03-08T00:51:49.278Z) OS version: Windows_NT x64 10.0.17763
System Info
|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2904)| |GPU Status|2d_canvas: enabledchecker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled| |Memory (System)|31.74GB (17.96GB free)| |Process Argv|| |Screen Reader|no| |VM|67%|
Extensions (21)
Extension|Author (truncated)|Version ---|---|--- better-comments|aar|2.0.3 overtype|ada|0.2.0 Bookmarks|ale|10.2.2 html-class-suggestions|And|1.0.7 color-info|bie|0.5.0 mustache|daw|1.1.1 vscode-eslint|dba|1.8.2 vscode-babel-coloring|dza|0.0.4 EditorConfig|Edi|0.13.0 file-icons|fil|1.0.16 auto-close-tag|for|0.5.6 duplicate|gee|1.0.1 beautify|Hoo|1.4.9 docthis|joe|0.7.1 vscode-duplicate|mrm|1.2.1 vscode-subword-navigation|ow|1.2.0 vscode-docker|Pet|0.6.0 vscode-versionlens|pfl|0.22.0 vscode-sort-json|ric|1.13.0 code-settings-sync|Sha|3.2.7 vscode-svg-previewer|vit|0.5.0